From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Joachim Eastwood <manabian@gmail.com>
Cc: <davem@davemloft.net>, <fengguang.wu@intel.com>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net/cadence: depend on HAS_IOMEM
Date: Mon, 29 Oct 2012 15:48:38 +0100 [thread overview]
Message-ID: <508E9746.9030406@atmel.com> (raw)
In-Reply-To: <1351339823-24987-1-git-send-email-manabian@gmail.com>
On 10/27/2012 02:10 PM, Joachim Eastwood :
> Fixes the following build failure on S390:
> In file included from drivers/net/ethernet/cadence/at91_ether.c:35:0:
> drivers/net/ethernet/cadence/macb.h: In function 'macb_is_gem':
> drivers/net/ethernet/cadence/macb.h:563:2: error: implicit declaration of function '__raw_readl' [-Werror=implicit-function-declaration]
> drivers/net/ethernet/cadence/at91_ether.c: In function 'update_mac_address':
> drivers/net/ethernet/cadence/at91_ether.c:119:2: error: implicit declaration of function '__raw_writel' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Joachim Eastwood <manabian@gmail.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/net/ethernet/cadence/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/cadence/Kconfig b/drivers/net/ethernet/cadence/Kconfig
> index 40172d1..ceb0de0 100644
> --- a/drivers/net/ethernet/cadence/Kconfig
> +++ b/drivers/net/ethernet/cadence/Kconfig
> @@ -4,6 +4,7 @@
>
> config NET_CADENCE
> bool "Cadence devices"
> + depends on HAS_IOMEM
> default y
> ---help---
> If you have a network (Ethernet) card belonging to this class, say Y.
>
--
Nicolas Ferre
prev parent reply other threads:[~2012-10-29 13:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 12:10 [PATCH net-next] net/cadence: depend on HAS_IOMEM Joachim Eastwood
2012-10-29 14:48 ` Nicolas Ferre [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508E9746.9030406@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=manabian@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.