From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:42646 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932701Ab2J2QdR (ORCPT ); Mon, 29 Oct 2012 12:33:17 -0400 Received: by mail-bk0-f46.google.com with SMTP id jk13so2078458bkc.19 for ; Mon, 29 Oct 2012 09:33:16 -0700 (PDT) Message-ID: <508EA1B8.3070304@googlemail.com> Date: Mon, 29 Oct 2012 17:33:12 +0200 From: =?UTF-8?B?RnJhbmsgU2Now6RmZXI=?= MIME-Version: 1.0 To: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org Subject: Re: [PATCH 00/23] em28xx: add support fur USB bulk transfers References: <1350838349-14763-1-git-send-email-fschaefer.oss@googlemail.com> <20121028175752.447c39d5@redhat.com> In-Reply-To: <20121028175752.447c39d5@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org List-ID: Am 28.10.2012 21:57, schrieb Mauro Carvalho Chehab: > Em Sun, 21 Oct 2012 19:52:05 +0300 > Frank Schäfer escreveu: > >> This patch series adds support for USB bulk transfers to the em28xx driver. >> >> Patch 1 is a bugfix for the image data processing with non-interlaced devices (webcams) >> that should be considered for stable (see commit message). >> >> Patches 2-21 extend the driver to support USB bulk transfers. >> USB endpoint mapping had to be extended and is a bit tricky. >> It might still not be sufficient to handle ALL isoc/bulk endpoints of ALL existing devices, >> but it should work with the devices we have seen so far and (most important !) >> preserves backwards compatibility to the current driver behavior. >> Isoc endpoints/transfers are preffered by default, patch 21 adds a module parameter to change this behavior. >> >> The last two patches are follow-up patches not really related to USB tranfers. >> Patch 22 reduces the code size in em28xx-video by merging the two URB data processing functions >> and patch 23 enables VBI-support for em2840-devices. >> >> Please note that I could test the changes with an analog non-interlaced non-VBI device only ! >> So further tests with DVB/interlaced/VBI devices are strongly recommended ! > Did a quick test here with all applied, with analog TV with xawtv and tvtime. > Didn't work. Ok, thanks for testing. > I'll need to postpone it, until I have more time to double check it and bisect. I would also need further informations about the test you've made (did you enable bulk ?) and the device you used (supports VBI ?). Regards, Frank > > Regards, > Mauro