From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37018) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSriF-00057i-Oe for qemu-devel@nongnu.org; Mon, 29 Oct 2012 11:57:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSri9-000761-QM for qemu-devel@nongnu.org; Mon, 29 Oct 2012 11:57:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSri9-00075w-Hy for qemu-devel@nongnu.org; Mon, 29 Oct 2012 11:57:09 -0400 Message-ID: <508EA74D.1040603@redhat.com> Date: Mon, 29 Oct 2012 17:57:01 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1351525013-9829-1-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1351525013-9829-1-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] pci_bridge: fix abort due to memory region API violation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: qemu-devel@nongnu.org, mst@redhat.com On 10/29/2012 05:36 PM, Michael Roth wrote: > 2be0e25f added an assertion that memory_region_destroy() is not called > during a transaction. pci_bridge_update_mappings() wants to do this so > that it can remove existing subregions and add new ones in their > place as an atomic operation. > > Work around this by storing away the old subregions and destroying them > after the transaction is complete. > An equivalent patch was already posted, see http://thread.gmane.org/gmane.comp.emulators.qemu/177418/focus=177853. -- error compiling committee.c: too many arguments to function