From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCH 2/4] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of Exynos4210 SOC Date: Mon, 29 Oct 2012 18:24:06 +0100 Message-ID: <508EBBB6.2090006@samsung.com> References: <1351504796-24788-1-git-send-email-b.zolnierkie@samsung.com> <1351504796-24788-3-git-send-email-b.zolnierkie@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:37743 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752492Ab2J2RYO (ORCPT ); Mon, 29 Oct 2012 13:24:14 -0400 In-Reply-To: <1351504796-24788-3-git-send-email-b.zolnierkie@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, jassisinghbrar@gmail.com, vinod.koul@intel.com, kgene.kim@samsung.com, rob.herring@calxeda.com, dinguyen@altera.com, pawel.moll@arm.com, t.figa@samsung.com, kyungmin.park@samsung.com On 10/29/12 10:59, Bartlomiej Zolnierkiewicz wrote: > Commit 8214513 ("ARM: EXYNOS: fix address for EXYNOS4 MDMA1") > changed EXYNOS specific setup of PL330 DMA engine to use 'non-secure' > mdma1 address instead of 'secure' one (from 0x12840000 to 0x12850000) > to fix issue with some Exynos4212 SOCs. Unfortunately it brakes > PL330 setup for revision 0 of Exynos4210 SOC (mdma1 device cannot > be found at 'non-secure' address): > > [ 0.566245] dma-pl330 dma-pl330.2: PERIPH_ID 0x0, PCELL_ID 0x0 ! > [ 0.566278] dma-pl330: probe of dma-pl330.2 failed with error -22 > > Fix it by using 'secure' mdma1 address on Exynos4210 revision 0 SOC. > > Cc: Tomasz Figa > Cc: Kukjin Kim > Signed-off-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-exynos/dma.c | 5 ++++- > arch/arm/mach-exynos/include/mach/map.h | 3 ++- > 2 files changed, 6 insertions(+), 2 deletions(-) [...] > + if (samsung_rev() == EXYNOS4210_REV_0) > + exynos_mdma1_device.res.start = EXYNOS4_PA_S_MDMA1; Hi Bart, Hmm...above change and adding definition of EXYNOS_PA_S_MDMA1 address can fix the problem you commented on EXYNOS4210 Rev0 without others?... Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Mon, 29 Oct 2012 18:24:06 +0100 Subject: [PATCH 2/4] ARM: EXYNOS: PL330 MDMA1 fix for revision 0 of Exynos4210 SOC In-Reply-To: <1351504796-24788-3-git-send-email-b.zolnierkie@samsung.com> References: <1351504796-24788-1-git-send-email-b.zolnierkie@samsung.com> <1351504796-24788-3-git-send-email-b.zolnierkie@samsung.com> Message-ID: <508EBBB6.2090006@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/29/12 10:59, Bartlomiej Zolnierkiewicz wrote: > Commit 8214513 ("ARM: EXYNOS: fix address for EXYNOS4 MDMA1") > changed EXYNOS specific setup of PL330 DMA engine to use 'non-secure' > mdma1 address instead of 'secure' one (from 0x12840000 to 0x12850000) > to fix issue with some Exynos4212 SOCs. Unfortunately it brakes > PL330 setup for revision 0 of Exynos4210 SOC (mdma1 device cannot > be found at 'non-secure' address): > > [ 0.566245] dma-pl330 dma-pl330.2: PERIPH_ID 0x0, PCELL_ID 0x0 ! > [ 0.566278] dma-pl330: probe of dma-pl330.2 failed with error -22 > > Fix it by using 'secure' mdma1 address on Exynos4210 revision 0 SOC. > > Cc: Tomasz Figa > Cc: Kukjin Kim > Signed-off-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-exynos/dma.c | 5 ++++- > arch/arm/mach-exynos/include/mach/map.h | 3 ++- > 2 files changed, 6 insertions(+), 2 deletions(-) [...] > + if (samsung_rev() == EXYNOS4210_REV_0) > + exynos_mdma1_device.res.start = EXYNOS4_PA_S_MDMA1; Hi Bart, Hmm...above change and adding definition of EXYNOS_PA_S_MDMA1 address can fix the problem you commented on EXYNOS4210 Rev0 without others?... Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.