From: Aaron Lu <aaron.lu@intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Alan Stern <stern@rowland.harvard.edu>, Tejun Heo <tj@kernel.org>,
Oliver Neukum <oliver@neukum.org>, Jeff Wu <jeff.wu@amd.com>,
Aaron Lu <aaron.lwe@gmail.com>, Shane Huang <shane.huang@amd.com>,
linux-ide@vger.kernel.org, linux-pm@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v8 02/11] ata: zpodd: Add CONFIG_SATA_ZPODD
Date: Tue, 30 Oct 2012 11:19:31 +0800 [thread overview]
Message-ID: <508F4743.3010905@intel.com> (raw)
In-Reply-To: <1351534282.3051.7.camel@dabdike>
On 10/30/2012 02:11 AM, James Bottomley wrote:
> On Mon, 2012-10-29 at 17:01 +0800, Aaron Lu wrote:
>> Added a new config CONFIG_SATA_ZPODD, which is ued to support
>> SATA based zero power ODD. It depends on ACPI, and selects BLK_DEV_SR
>> as the implementation of ZPODD depends on SCSI sr driver.
>>
>> 2 new files are added, which will be used to host ZPODD related code.
>> They are empty for this commit.
>
> I think you actually need to combine this with patch 3 to have it
> compile ...
I remembered I tested this, and I just tested the compile again, with
the CONFIG_SATA_ZPODD both on and off, and it didn't have any compile
issue, so I'm not sure if this is a problem...
-Aaron
>
> James
>
>
>> Signed-off-by: Aaron Lu <aaron.lu@intel.com>
>> ---
>> drivers/ata/Kconfig | 12 ++++++++++++
>> drivers/ata/Makefile | 1 +
>> 2 files changed, 13 insertions(+)
>> create mode 100644 drivers/ata/sata_zpodd.c
>> create mode 100644 drivers/ata/sata_zpodd.h
>>
>> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
>> index e08d322..2cdecee 100644
>> --- a/drivers/ata/Kconfig
>> +++ b/drivers/ata/Kconfig
>> @@ -58,6 +58,18 @@ config ATA_ACPI
>> You can disable this at kernel boot time by using the
>> option libata.noacpi=1
>>
>> +config SATA_ZPODD
>> + bool "SATA Zero Power ODD Support"
>> + depends on ACPI
>> + select BLK_DEV_SR
>> + default n
>> + help
>> + This option adds support for SATA ZPODD. It requires both
>> + ODD and the platform support, and if enabled, will automatically
>> + power on/off the ODD when certain condition is satisfied. This
>> + does not impact user's experience of the ODD, only power is saved
>> + when ODD is not in use(i.e. no disc inside).
>> +
>> config SATA_PMP
>> bool "SATA Port Multiplier support"
>> default y
>> diff --git a/drivers/ata/Makefile b/drivers/ata/Makefile
>> index 9329daf..a5120ff 100644
>> --- a/drivers/ata/Makefile
>> +++ b/drivers/ata/Makefile
>> @@ -107,3 +107,4 @@ libata-y := libata-core.o libata-scsi.o libata-eh.o libata-transport.o
>> libata-$(CONFIG_ATA_SFF) += libata-sff.o
>> libata-$(CONFIG_SATA_PMP) += libata-pmp.o
>> libata-$(CONFIG_ATA_ACPI) += libata-acpi.o
>> +obj-$(CONFIG_SATA_ZPODD) += sata_zpodd.o
>> diff --git a/drivers/ata/sata_zpodd.c b/drivers/ata/sata_zpodd.c
>> new file mode 100644
>> index 0000000..e69de29
>> diff --git a/drivers/ata/sata_zpodd.h b/drivers/ata/sata_zpodd.h
>> new file mode 100644
>> index 0000000..e69de29
>
>
next prev parent reply other threads:[~2012-10-30 3:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 9:01 [PATCH v8 00/11] ZPODD Patches Aaron Lu
2012-10-29 9:01 ` [PATCH v8 01/11] scsi: sr: support runtime pm Aaron Lu
2012-10-29 9:01 ` [PATCH v8 02/11] ata: zpodd: Add CONFIG_SATA_ZPODD Aaron Lu
2012-10-29 18:11 ` James Bottomley
2012-10-30 3:19 ` Aaron Lu [this message]
2012-10-29 9:01 ` [PATCH v8 03/11] ata: zpodd: identify and init ZPODD devices Aaron Lu
2012-10-29 9:01 ` [PATCH v8 04/11] libata: acpi: move acpi notification code to sata_zpodd Aaron Lu
2012-10-29 9:01 ` [PATCH v8 05/11] libata-eh: allow defer in ata_exec_internal Aaron Lu
2012-10-29 15:20 ` Tejun Heo
2012-10-30 3:00 ` Aaron Lu
2012-10-30 3:01 ` Tejun Heo
2012-10-30 3:09 ` Aaron Lu
2012-10-31 21:52 ` Tejun Heo
2012-11-01 2:35 ` Aaron Lu
2012-11-01 16:03 ` Tejun Heo
2012-11-02 0:43 ` Aaron Lu
2012-10-29 9:01 ` [PATCH v8 06/11] ata: zpodd: check loading mechanism for ODD Aaron Lu
2012-10-29 9:01 ` [PATCH v8 07/11] libata: separate ATAPI code Aaron Lu
2012-10-29 9:01 ` [PATCH v8 08/11] ata: zpodd: check zero power ready status Aaron Lu
2012-10-29 9:01 ` [PATCH v8 09/11] block: add a new interface to block events Aaron Lu
2012-10-29 15:35 ` Tejun Heo
2012-10-30 7:04 ` Aaron Lu
2012-10-31 21:51 ` Tejun Heo
2012-11-01 6:30 ` Aaron Lu
2012-10-29 9:01 ` [PATCH v8 10/11] scsi: sr: support (un)block events Aaron Lu
2012-10-29 18:11 ` James Bottomley
2012-10-29 22:22 ` Alan Stern
2012-10-30 4:34 ` James Bottomley
2012-10-30 5:02 ` Aaron Lu
2012-10-29 9:01 ` [PATCH v8 11/11] ata: zpodd: handle power transition of ODD Aaron Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508F4743.3010905@intel.com \
--to=aaron.lu@intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=aaron.lwe@gmail.com \
--cc=jeff.wu@amd.com \
--cc=jgarzik@pobox.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=rjw@sisk.pl \
--cc=shane.huang@amd.com \
--cc=stern@rowland.harvard.edu \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.