From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60398)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1TT7Ev-0003F5-Nb
	for qemu-devel@nongnu.org; Tue, 30 Oct 2012 04:32:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1TT7Eu-0000L0-Ke
	for qemu-devel@nongnu.org; Tue, 30 Oct 2012 04:32:01 -0400
Received: from thoth.sbs.de ([192.35.17.2]:29371)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1TT7Eu-0000Km-Af
	for qemu-devel@nongnu.org; Tue, 30 Oct 2012 04:32:00 -0400
Message-ID: <508F907A.2080107@siemens.com>
Date: Tue, 30 Oct 2012 09:31:54 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <cover.1351427134.git.blauwirbel@gmail.com>
	<20646c072ced410321c404397f1ff8afb8051930.1351427134.git.blauwirbel@gmail.com>
In-Reply-To: <20646c072ced410321c404397f1ff8afb8051930.1351427134.git.blauwirbel@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] slirp: remove unused function u_sleep
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 2012-10-28 13:26, Blue Swirl wrote:
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
>  slirp/misc.c |   14 --------------
>  slirp/misc.h |    1 -
>  2 files changed, 0 insertions(+), 15 deletions(-)
> 
> diff --git a/slirp/misc.c b/slirp/misc.c
> index 0bee864..664532a 100644
> --- a/slirp/misc.c
> +++ b/slirp/misc.c
> @@ -253,20 +253,6 @@ void lprint(const char *format, ...)
>      va_end(args);
>  }
>  
> -void
> -u_sleep(int usec)
> -{
> -	struct timeval t;
> -	fd_set fdset;
> -
> -	FD_ZERO(&fdset);
> -
> -	t.tv_sec = 0;
> -	t.tv_usec = usec * 1000;
> -
> -	select(0, &fdset, &fdset, &fdset, &t);
> -}
> -
>  void slirp_connection_info(Slirp *slirp, Monitor *mon)
>  {
>      const char * const tcpstates[] = {
> diff --git a/slirp/misc.h b/slirp/misc.h
> index ed40a10..cc36aeb 100644
> --- a/slirp/misc.h
> +++ b/slirp/misc.h
> @@ -64,7 +64,6 @@ void snooze_hup(int);
>  void snooze(void);
>  void relay(int);
>  void add_emu(char *);
> -void u_sleep(int);
>  void fd_nonblock(int);
>  void fd_block(int);
>  int rsh_exec(struct socket *, struct socket *, char *, char *, char *);
> 

It's obviously fine. But wasn't it already merged or accepted for
trivial? Of course, I can take it otherwise.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux