From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Chapman Subject: Re: switching network namespace midway Date: Tue, 30 Oct 2012 08:55:43 +0000 Message-ID: <508F960F.20104@katalix.com> References: <878vavshhp.fsf@xmission.com> <20121024212116.GG15034@kvack.org> <87ip9zqqlv.fsf@xmission.com> <20121025143811.GH15034@kvack.org> <20121025092105.5119b8bf@nehalam.linuxnetplumber.net> <877gqb883y.fsf@xmission.com> <20121029072341.158e6412@nehalam.linuxnetplumber.net> <87a9v47qsl.fsf@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , Benjamin LaHaise , rsa , netdev@vger.kernel.org To: "Eric W. Biederman" Return-path: Received: from katalix.com ([82.103.140.233]:60757 "EHLO mail.katalix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751284Ab2J3JFm (ORCPT ); Tue, 30 Oct 2012 05:05:42 -0400 In-Reply-To: <87a9v47qsl.fsf@xmission.com> Sender: netdev-owner@vger.kernel.org List-ID: On 30/10/12 00:21, Eric W. Biederman wrote: > Stephen Hemminger writes: > >> On Sat, 27 Oct 2012 22:43:13 -0700 >> ebiederm@xmission.com (Eric W. Biederman) wrote: >> >>> Stephen Hemminger writes: >>> >>>> I noticed that the L2TP sockets are not being moved to the correct name >>>> space. >>>> >>>> Something like this is probably needed. >>> >>> This is almost right. >>> >>> There needs to be a line in l2tp_tunnel_create that verifies >>> the network namespace of the socket derived from a file descriptor >>> and the passed in network namespace match. >>> >>> For the l2tp_tunnel_sock_create case where we have a socket that is not >>> exported to userspace using sk_change_net seems appropriate to avoid >>> reference counting problems. And it may be worth moving that work into >>> sk_create_kern. But we need a network namespace hook that will lookup >>> all l2tp tunnel sockets when a network namespace is being destroyed and >>> remove them. I think we can hit this bug with rmmod as well. >> >> Since I don't use netns or L2TP for real, someone else needs to take >> up the crusade here. > > Let's see if James Chapman is interested. I don't use L2TP for real either. > > James are you at all interested in the network namespace bugs that have > been found in the l2tp code? Very much so, Eric. Thanks for keeping me in the loop. Unfortunately, I am busy on other things at the moment. It's in my queue. I'll get to it as soon as I can. > > Eric -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development