From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756890Ab2J3JA1 (ORCPT ); Tue, 30 Oct 2012 05:00:27 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]:35468 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756427Ab2J3JAY (ORCPT ); Tue, 30 Oct 2012 05:00:24 -0400 Message-ID: <508F9724.50804@linaro.org> Date: Tue, 30 Oct 2012 10:00:20 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Viresh Kumar CC: Ben Hutchings , netdev@vger.kernel.org, linaro-dev@lists.linaro.org, davem@davemloft.net, linux-kernel@vger.kernel.org, patches@linaro.org Subject: Re: [PATCH] net: dsa/slave: Fix compilation warnings References: <5afab1ebe83e4361f1fd75bbea0c559af195bf02.1351529738.git.viresh.kumar@linaro.org> <1351540778.2721.7.camel@bwh-desktop.uk.solarflarecom.com> <508F8779.8070300@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/2012 08:55 AM, Viresh Kumar wrote: > On 30 October 2012 13:23, Daniel Lezcano wrote: >>> From: Viresh Kumar > >>> config NET_DSA_TAG_DSA >>> - bool >>> + bool "Original DSA packet tagging format" >>> + select NET_DSt >> >> typo NET_DSA > > Unbelievable mistake :( > > Will fix it after some reviews now :) Yeah, has to be ! ;) It is very curious if we disable all the configs option, a slave creation raise a BUG (cf. dsa_slave_create). IIUC, booting with NET_DSA enabled and none of the NET_DSA_TAG* enabled will raise a BUG in the probe function, right ? Maybe we should force at least one config when none are set ? diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig index 274791c..86326e3 100644 --- a/net/dsa/Kconfig +++ b/net/dsa/Kconfig @@ -1,8 +1,9 @@ -config NET_DSA +menuconfig NET_DSA tristate "Distributed Switch Architecture support" default n depends on EXPERIMENTAL && NETDEVICES && !S390 select PHYLIB + select NET_DSA_TAG_DSA if (!NET_DSA_TAG_EDSA && !NET_DSA_TAG_TRAILER) ---help--- This allows you to use hardware switch chips that use the Distributed Switch Architecture. @@ -12,15 +13,15 @@ if NET_DSA # tagging formats config NET_DSA_TAG_DSA - bool + bool "tag dsa" default n config NET_DSA_TAG_EDSA - bool + bool "tag edsa" default n config NET_DSA_TAG_TRAILER - bool + bool "tag trailer" default n endif -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog