From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:54156 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932453Ab2J3NYi (ORCPT ); Tue, 30 Oct 2012 09:24:38 -0400 Message-ID: <508FD50F.1060105@suse.cz> Date: Tue, 30 Oct 2012 14:24:31 +0100 From: Michal Marek MIME-Version: 1.0 Subject: Re: [PATCH] fbdev: make scripts/pnmtologo dependency portable References: <1350352380-5324-1-git-send-email-yselkowitz@users.sourceforge.net> In-Reply-To: <1350352380-5324-1-git-send-email-yselkowitz@users.sourceforge.net> Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: "Yaakov (Cygwin/X)" Cc: linux-kbuild@vger.kernel.org On 16.10.2012 03:53, Yaakov (Cygwin/X) wrote: > From: Yaakov Selkowitz > > Commit a53c9d5b7115173fba9f82ff8120b624ef206f48 added a dependency on > scripts/pnmtologo to all autogenerated .c files. An explicit rule > is required on platforms where the .exe suffix is used for hostprogs. > > Signed-off-by: Yaakov Selkowitz > --- > Michal, > > This was originally sent to linux-fbdev, but was forwarded to linux-kbuild > (but not you) on 12 June. It has yet to be applied to Linus' tree yet, though. > > Also applies to all 3.x stable branches > > drivers/video/logo/Makefile | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/video/logo/Makefile b/drivers/video/logo/Makefile > index 3b43781..3854dbb 100644 > --- a/drivers/video/logo/Makefile > +++ b/drivers/video/logo/Makefile > @@ -38,6 +38,7 @@ extra-y += $(call logo-cfiles,_clut224,ppm) > extra-y += $(call logo-cfiles,_gray256,pgm) > > pnmtologo := scripts/pnmtologo > +$(pnmtologo): $(objtree)/scripts/pnmtologo Please add an explanation to the changelog how it works. scripts/pnmtologo is dependent on $(objtree)/scripts/pnmtologo (same file??), how does it fix the problem that the file is called scripts/pnmtologo.exe on Cygwin? I do not see any rule for hostprog.exe -> hostprog in our makefiles. Michal