From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] irqchip: Move ARM GIC to drivers/irqchip
Date: Tue, 30 Oct 2012 11:05:48 -0500 [thread overview]
Message-ID: <508FFADC.3080506@gmail.com> (raw)
In-Reply-To: <20121030160129.7e39619b@skate>
On 10/30/2012 10:01 AM, Thomas Petazzoni wrote:
> Rob,
>
> On Tue, 30 Oct 2012 09:54:18 -0500, Rob Herring wrote:
>> From: Rob Herring <rob.herring@calxeda.com>
>>
>> Now that we have drivers/irqchip, move GIC irqchip to drivers/irqchip. This
>> is necessary to share the GIC with arm and arm64.
>>
>> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
>> Cc: Russell King <linux@arm.linux.org.uk>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> ---
>> arch/arm/common/Kconfig | 8 --------
>> arch/arm/common/Makefile | 1 -
>> drivers/irqchip/Kconfig | 8 ++++++++
>> drivers/irqchip/Makefile | 1 +
>> arch/arm/common/gic.c => drivers/irqchip/irq-gic.c | 0
>> drivers/irqchip/irqchip.c | 10 ++++++++++
>> drivers/irqchip/irqchip.h | 1 +
>> 7 files changed, 20 insertions(+), 9 deletions(-)
>
> What about arch/arm/include/asm/hardware/gic.h ?
>
> Contrary to the current version of the bcm2835 IRQ controller driver
> and the armada-370-xp IRQ controller driver, the GIC and VIC drivers
> not only expose a <foo>_of_init() function, but also other functions
> that are directly used by several non-DT capable ARM sub-architectures.
>
> Of course, it works by leaving gic.h where it is now, but it sounds
> strange to have the driver in drivers/irqchip/ and the header file in
> arch/arm/include/asm/hardware/, especially if the goal is to be able to
> use those drivers in arm64.
Right. I'll have to move it. I wasn't really thinking about arm64 until
this morning.
Rob
next prev parent reply other threads:[~2012-10-30 16:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 14:54 [PATCH 0/7] Move GIC and VIC to drivers/irqchip Rob Herring
2012-10-30 14:54 ` [PATCH 1/3] irqchip: Move ARM GIC " Rob Herring
2012-10-30 15:01 ` Thomas Petazzoni
2012-10-30 16:05 ` Rob Herring [this message]
2012-10-30 17:21 ` Rob Herring
2012-10-30 22:30 ` Thomas Petazzoni
2012-10-30 22:47 ` Russell King - ARM Linux
2012-10-31 0:04 ` Rob Herring
2012-10-31 9:05 ` Russell King - ARM Linux
2012-10-31 11:56 ` Catalin Marinas
2012-10-31 14:29 ` Rob Herring
2012-10-31 15:07 ` Russell King - ARM Linux
2012-10-30 14:54 ` [PATCH 2/3] irqchip: Move ARM VIC " Rob Herring
2012-10-30 18:27 ` Stephen Warren
2012-10-30 14:54 ` [PATCH 3/3] ARM: highbank: use common irqchip_init Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508FFADC.3080506@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.