From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47755)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1baNke-00026c-E0
	for qemu-devel@nongnu.org; Thu, 18 Aug 2016 09:52:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1baNkc-0004IU-L6
	for qemu-devel@nongnu.org; Thu, 18 Aug 2016 09:52:55 -0400
References: <1468901281-22858-1-git-send-email-eblake@redhat.com>
	<1468901281-22858-14-git-send-email-eblake@redhat.com>
	<57B5BD30.9030006@virtuozzo.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <508fee68-e0bf-3ac7-d7e9-a3cbc9fc7281@redhat.com>
Date: Thu, 18 Aug 2016 15:52:42 +0200
MIME-Version: 1.0
In-Reply-To: <57B5BD30.9030006@virtuozzo.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 13/14] nbd: Implement
 NBD_CMD_WRITE_ZEROES on server
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>, Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>



On 18/08/2016 15:50, Vladimir Sementsov-Ogievskiy wrote:
> 
> from nbd proto.md:
> 
> "Finally, it SHOULD return |EPERM| if it receives a write or trim
> request on a read-only export."
> 
> And EROFS is not mentioned in proto.md
> 
> (however the same bug is in NBD_CMD_WRITE case.)

system_errno_to_nbd_errno takes care of fixing up the return value.

Paolo