From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH 1/2] autoconf: check for wget and ftp Date: Tue, 30 Oct 2012 17:32:29 +0100 Message-ID: <5090011D.9080406@citrix.com> References: <1351588958-75040-1-git-send-email-roger.pau@citrix.com> <20623.60420.97632.890498@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20623.60420.97632.890498@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Christoph Egger , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 30/10/12 16:02, Ian Jackson wrote: > Roger Pau Monne writes ("[Xen-devel] [PATCH 1/2] autoconf: check for wget and ftp"): >> Some OSes don't come with wget by default, so ftp should be choosen >> on those. Add an autoconf check to check for wget and ftp, and >> replace the usage of hardcoded wget in tools. > > I don't think this can be right; wget is used in many more places. At > the very least it looks like it will break the stubdom build since > that is full of WGET. Did you grep for WGET ? Does stubdom build import config/Tools.mk? I thought it was only used to build the tools directory. If that's the case I don't think it will break anything, since we define a new variable $FETCHER, that shouldn't be used anywhere else, so the rest will continue to use the hardcoded wget, or whatever it was using prior to this patch. > Does "ftp -o blah.tar.gz http://xenbits.xen.org/xen-extfiles/blah.tar.gz" > really work on NetBSD and download to the local file "blah.tar.gz" ? Yes.