All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Christoph Egger <Christoph.Egger@amd.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH 1/2] autoconf: check for wget and ftp
Date: Tue, 30 Oct 2012 18:48:00 +0100	[thread overview]
Message-ID: <509012D0.8030501@citrix.com> (raw)
In-Reply-To: <20624.3892.618566.138065@mariner.uk.xensource.com>

On 30/10/12 18:32, Ian Jackson wrote:
> Roger Pau Monné writes ("Re: [Xen-devel] [PATCH 1/2] autoconf: check for wget and ftp"):
>> On 30/10/12 16:02, Ian Jackson wrote:
>>> I don't think this can be right; wget is used in many more places.  At
>>> the very least it looks like it will break the stubdom build since
>>> that is full of WGET.  Did you grep for WGET ?
>>
>> Does stubdom build import config/Tools.mk? I thought it was only used to
>> build the tools directory. If that's the case I don't think it will
>> break anything, since we define a new variable $FETCHER, that shouldn't
>> be used anywhere else, so the rest will continue to use the hardcoded
>> wget, or whatever it was using prior to this patch.
> 
> Err, yes, it seems stubdom/Makefile has its own definition of wget.
> But stubdom builds are still going to be broken without wget then ?

Yes, but I don't think we should check for the requirements of stubdoms
build process if we are not going to include config/Tools.mk to build
them. For example NetBSD cannot build stubdoms (for other reasons), so
we shouldn't enforce wget presence in configure.

  reply	other threads:[~2012-10-30 17:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-30  9:22 [PATCH 1/2] autoconf: check for wget and ftp Roger Pau Monne
2012-10-30  9:22 ` [PATCH 2/2] autoconf: bash is not needed on NetBSD Roger Pau Monne
2012-10-30 14:58   ` Ian Jackson
2012-10-30 15:02 ` [PATCH 1/2] autoconf: check for wget and ftp Ian Jackson
2012-10-30 16:32   ` Roger Pau Monné
2012-10-30 17:32     ` Ian Jackson
2012-10-30 17:48       ` Roger Pau Monné [this message]
2012-10-30 18:11         ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509012D0.8030501@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=Christoph.Egger@amd.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.