From: Rich Johnston <rjohnston@sgi.com>
To: Tomas Racek <tracek@redhat.com>
Cc: lczerner@redhat.com, xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] 289: Test that filesystem sends discard requests only on free sectors
Date: Tue, 30 Oct 2012 15:18:03 -0500 [thread overview]
Message-ID: <509035FB.2080402@sgi.com> (raw)
In-Reply-To: <1350549946-17192-3-git-send-email-tracek@redhat.com>
On 10/18/2012 03:45 AM, Tomas Racek wrote:
> This is done by comparing free sectors reported by some FS utility
> (dumpe2fs/xfs_db) and actual discard commands sent to device obtained
> via blk tracer in debugfs.
>
> Currently supported FS are ext[34], xfs; device with discard support is
> not required, the test creates loop device for this purpose.
>
> Signed-off-by: Tomas Racek <tracek@redhat.com>
> ---
> 289 | 169 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 289.out | 5 ++
> group | 1 +
> 3 files changed, 175 insertions(+)
> create mode 100755 289
> create mode 100644 289.out
>
This will not work for 3.x kernels, but they 2.6 and 3.x both use the
same path.
> +debugfs=$($MOUNT_PROG | grep debugfs | cut -d " " -f3)
> +[ -n $debugfs ] || _notrun "This test requires mounted debugfs"
As you use $debugfs quite a bit from here on, suggest doing something like:
debugfs=/sys/kernel/debug
if [ ! -d $debugfs ]; then
_notrun "This test requires mounted debugfs"
fi
Other than that it looks great.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-30 20:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 8:45 [PATCH 1/3] Add new standard loop handling functions Tomas Racek
2012-10-18 8:45 ` [PATCH 2/3] Provide dumpe2fs via standard common.config interface Tomas Racek
2012-10-30 20:18 ` Rich Johnston
2012-10-18 8:45 ` [PATCH 3/3] 289: Test that filesystem sends discard requests only on free sectors Tomas Racek
2012-10-30 20:18 ` Rich Johnston [this message]
2012-10-30 21:18 ` Dave Chinner
2012-10-30 20:17 ` [PATCH 1/3] Add new standard loop handling functions Rich Johnston
2012-10-30 20:40 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509035FB.2080402@sgi.com \
--to=rjohnston@sgi.com \
--cc=lczerner@redhat.com \
--cc=tracek@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.