From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH V3 0/4] ARM: tegra: Enable SLINK controller driver Date: Tue, 30 Oct 2012 14:29:46 -0600 Message-ID: <509038BA.30600@wwwdotorg.org> References: <1351580726-17350-1-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1351580726-17350-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan Cc: linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 10/30/2012 01:05 AM, Laxman Dewangan wrote: > This series modify the dts file to add the slink addresses, > make AUXDATA in board dt files, enable slink4 for tegra30-cardhu and > enable slink controller defconfig. This series only instantiates the SPI controller, and not any SPI devices. I tried to solve this: > diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi > index 700f0a3..3689853 100644 > --- a/arch/arm/boot/dts/tegra30-cardhu.dtsi > +++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi > @@ -278,6 +278,11 @@ > spi@7000da00 { > status = "okay"; > spi-max-frequency = <25000000>; > + flash@0 { > + reg = <0>; > + compatible = "atmel,at25df321a"; > + spi-max-frequency = <25000000>; > + }; > }; > > ahub { However, this didn't work. Has the driver been tested? I'm seeing the exact same problems I saw with the old driver, namely that the SPI flash chip can't be identified; I think the ID bytes are read back as 0, and hence drivers/mtd/devices/m25p80.c falls back to identifying the device as mr25h256. Attempting to hexdump -C /dev/mtd0 gives me 32K of zeros, whereas the device is 4M and full of non-zero data according to U-Boot. Do you know what the problem is here? Can you please update the patch series so that the SPI flash is instantiated and works correctly? From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Tue, 30 Oct 2012 14:29:46 -0600 Subject: [PATCH V3 0/4] ARM: tegra: Enable SLINK controller driver In-Reply-To: <1351580726-17350-1-git-send-email-ldewangan@nvidia.com> References: <1351580726-17350-1-git-send-email-ldewangan@nvidia.com> Message-ID: <509038BA.30600@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/30/2012 01:05 AM, Laxman Dewangan wrote: > This series modify the dts file to add the slink addresses, > make AUXDATA in board dt files, enable slink4 for tegra30-cardhu and > enable slink controller defconfig. This series only instantiates the SPI controller, and not any SPI devices. I tried to solve this: > diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi > index 700f0a3..3689853 100644 > --- a/arch/arm/boot/dts/tegra30-cardhu.dtsi > +++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi > @@ -278,6 +278,11 @@ > spi at 7000da00 { > status = "okay"; > spi-max-frequency = <25000000>; > + flash at 0 { > + reg = <0>; > + compatible = "atmel,at25df321a"; > + spi-max-frequency = <25000000>; > + }; > }; > > ahub { However, this didn't work. Has the driver been tested? I'm seeing the exact same problems I saw with the old driver, namely that the SPI flash chip can't be identified; I think the ID bytes are read back as 0, and hence drivers/mtd/devices/m25p80.c falls back to identifying the device as mr25h256. Attempting to hexdump -C /dev/mtd0 gives me 32K of zeros, whereas the device is 4M and full of non-zero data according to U-Boot. Do you know what the problem is here? Can you please update the patch series so that the SPI flash is instantiated and works correctly? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934508Ab2J3U3v (ORCPT ); Tue, 30 Oct 2012 16:29:51 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:57070 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934293Ab2J3U3u (ORCPT ); Tue, 30 Oct 2012 16:29:50 -0400 Message-ID: <509038BA.30600@wwwdotorg.org> Date: Tue, 30 Oct 2012 14:29:46 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120912 Thunderbird/15.0.1 MIME-Version: 1.0 To: Laxman Dewangan CC: linux@arm.linux.org.uk, linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 0/4] ARM: tegra: Enable SLINK controller driver References: <1351580726-17350-1-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1351580726-17350-1-git-send-email-ldewangan@nvidia.com> X-Enigmail-Version: 1.4.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/2012 01:05 AM, Laxman Dewangan wrote: > This series modify the dts file to add the slink addresses, > make AUXDATA in board dt files, enable slink4 for tegra30-cardhu and > enable slink controller defconfig. This series only instantiates the SPI controller, and not any SPI devices. I tried to solve this: > diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm/boot/dts/tegra30-cardhu.dtsi > index 700f0a3..3689853 100644 > --- a/arch/arm/boot/dts/tegra30-cardhu.dtsi > +++ b/arch/arm/boot/dts/tegra30-cardhu.dtsi > @@ -278,6 +278,11 @@ > spi@7000da00 { > status = "okay"; > spi-max-frequency = <25000000>; > + flash@0 { > + reg = <0>; > + compatible = "atmel,at25df321a"; > + spi-max-frequency = <25000000>; > + }; > }; > > ahub { However, this didn't work. Has the driver been tested? I'm seeing the exact same problems I saw with the old driver, namely that the SPI flash chip can't be identified; I think the ID bytes are read back as 0, and hence drivers/mtd/devices/m25p80.c falls back to identifying the device as mr25h256. Attempting to hexdump -C /dev/mtd0 gives me 32K of zeros, whereas the device is 4M and full of non-zero data according to U-Boot. Do you know what the problem is here? Can you please update the patch series so that the SPI flash is instantiated and works correctly?