From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 7/8] am33xx_spl_bch: simple SPL nand loader for AM33XX
Date: Tue, 30 Oct 2012 17:03:22 -0700 [thread overview]
Message-ID: <50906ACA.4050603@ti.com> (raw)
In-Reply-To: <1351637263-17464-8-git-send-email-ilya.yanok@cogentembedded.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 10/30/12 15:47, Ilya Yanok wrote:
> AM33XX with BCH8 can't work with nand_spl_simple correctly because
> custom read_page implementation is required for proper syndrome
> generation.
>
> This simple driver mostly duplicates nand_spl_simple but has
> nand_read_page changed to suit our needs.
[snip]
> + for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize) {
> + this->ecc.hwctl(&mtd, NAND_ECC_READ); + nand_command(block,
> page, data_pos, NAND_CMD_RNDOUT); + + this->read_buf(&mtd, p,
> eccsize); + + nand_command(block, page, oob_pos,
> NAND_CMD_RNDOUT); + + this->read_buf(&mtd, oob, eccbytes); +
> this->ecc.calculate(&mtd, p, &ecc_calc[i]); + + data_pos +=
> eccsize; + oob_pos += eccbytes; + oob += eccbytes; + }
This is where the function differs. If we can't merge things
together, I'd like to see about putting just this function into
nand_spl_simple.c under CONFIG_SYS_NAND_HW_BCH8 since if I follow
what's going on, and I need to play with the code to confirm I do,
it's a generic change related to how much more we're reading back out
now. But good catch finding what was going wrong with nand_spl_simple
here.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iQIcBAEBAgAGBQJQkGrJAAoJENk4IS6UOR1WnqMP/3i/zWcvB7iZhjl5HvrlrYuQ
+6ijXtQzWCROKP/gERTQjKlVOj09jEGvHY5Ac5xpiMqtxvCAxDyz88fu5CWJgtlT
gZJqq7WPaR21FHJzS5GinL7oQBNMY9/m1wNVCVHq971Lq4VxgfYPXdPMytiMPxOy
ExoB034z6KkaFR7FdRFLMZeT9ri292jFlmZuNpyKjjEYigI4+WH4FvlkFxEpL18w
F+bXWzp4Krd8ndgM3OjvzJWmPZxU3M1YjHKOn631W8T2Q7bMe6yOH9PEYKiqQuTG
wniwcmxB6n2vT04enyuUPCfyNA9OPJv7w+pGWdrYXjU22CHUbNfywJZC7sqmYeht
uUhvvdF8jtJFHpK1RScF69Gy2xcmtIa7PPMmLkv3JbtnLgw91NyeM+tuzty2/MIA
icsbE1PwxvLGSMlvJJhag82oKb4kYZ1I5SSmd5aJkyt21CbXiBKf6M+Vsx8TmyCh
03XTuN7iuMpm4jlEed4bv64yLZ7suJxu60XtKAH5yX5S6L8PI+SAEpzknLdqCf7j
A2z8YyLZEaxa27oxOmY4/G8KTpZrPNkei4jL9VOd7wkZ/j9TRUZ6rzrIHVuwWlqS
oVJt/qHq+zznQFZF3iI3kPUtiU1FpiPycPzSevH+V3gZNFdNF1Ze9+VqEyW2QV60
nVRZjXS9VSKeR43dXBgg
=giFN
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-10-31 0:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 22:47 [U-Boot] [PATCH v1 0/8] NAND support for AM33XX Ilya Yanok
2012-10-30 22:47 ` [U-Boot] [PATCH v1 1/8] OMAP: include sys_proto.h from boot-common Ilya Yanok
2012-10-30 22:47 ` [U-Boot] [PATCH v1 2/8] am335x_evm: add nand pinmux definition Ilya Yanok
2012-10-30 23:45 ` Tom Rini
2012-10-30 22:47 ` [U-Boot] [PATCH v1 3/8] am33xx: NAND support Ilya Yanok
2012-10-30 23:51 ` Tom Rini
2012-10-30 22:47 ` [U-Boot] [PATCH v1 4/8] am335x_evm: enable " Ilya Yanok
2012-10-30 23:53 ` Tom Rini
2012-10-30 22:47 ` [U-Boot] [PATCH v1 5/8] am33xx: add ELM support Ilya Yanok
2012-10-30 23:54 ` Tom Rini
2012-10-30 22:47 ` [U-Boot] [PATCH v1 6/8] omap_gpmc: BCH8 support (ELM based) Ilya Yanok
2012-10-30 22:47 ` [U-Boot] [PATCH v1 7/8] am33xx_spl_bch: simple SPL nand loader for AM33XX Ilya Yanok
2012-10-31 0:03 ` Tom Rini [this message]
2012-11-03 16:21 ` Ilya Yanok
2012-11-05 16:57 ` Tom Rini
2012-10-30 22:47 ` [U-Boot] [PATCH v1 8/8] am335x_evm: enable SPL NAND support Ilya Yanok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50906ACA.4050603@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.