From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTUcZ-0003jD-64 for qemu-devel@nongnu.org; Wed, 31 Oct 2012 05:30:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTUcT-0007yZ-3K for qemu-devel@nongnu.org; Wed, 31 Oct 2012 05:29:59 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:24122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTUcS-0007tR-TX for qemu-devel@nongnu.org; Wed, 31 Oct 2012 05:29:53 -0400 Received: from eusync4.samsung.com (mailout3.w1.samsung.com [210.118.77.13]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MCR00C403QFD680@mailout3.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 31 Oct 2012 09:30:15 +0000 (GMT) Received: from [106.109.8.87] by eusync4.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MCR004AH3PNIX90@eusync4.samsung.com> for qemu-devel@nongnu.org; Wed, 31 Oct 2012 09:29:48 +0000 (GMT) Message-id: <5090EF8A.3030804@samsung.com> Date: Wed, 31 Oct 2012 13:29:46 +0400 From: Igor Mitsyanko MIME-version: 1.0 References: In-reply-to: Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit Subject: Re: [Qemu-devel] [RFC] Configure option to turn on all debug printerfy Reply-To: i.mitsyanko@samsung.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Kyungmin Park , "qemu-devel@nongnu.org Developers" On 10/31/2012 07:10 AM, Peter Crosthwaite wrote: > So in a couple of cases now I have done work on mature device models > that include #ifdef'd debug printfery that is broken, and have > submitted (trivial) patches to fix. Whats happening is tree wide or > automated changes (changing types of variables etc) is causing the > debug printfery to break, usually werror issues on %x in printfs due > to types. Issue is, it never gets detected until someone tries to use > the debug mode: ./configure --extra-cflags="-DFOO_DEBUG". Can we have > some sort of alternate symbol "ALL_DEBUG" or something, such that > every debug printf is compiled? Then when developers make tree wide > changes they can at least compile test for breakages in debug printfs > using ./configure --extra-cflags="-DALL_DEBUG"? It would be fairly > trivial to implement. > > Regards, > Peter > Agree, I think majority of device-specific debugging was broken after ARM physical address length was changed to 64 bit. Of course, no one would want to run QEMU with ALL_DEBUG, but I think no one wants to configure QEMU with --target-list=all either, but sometimes we have to) But touching every device could be too invasive, maybe add new target to QEMU makefile "make compile-test", and ask for every new contributor to manually add his debug define in some kind of list of defines for "make compile-test". -- Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsyanko@samsung.com