From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:51447 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751588Ab2JaMuW (ORCPT ); Wed, 31 Oct 2012 08:50:22 -0400 Received: by mail-bk0-f46.google.com with SMTP id jk13so632784bkc.19 for ; Wed, 31 Oct 2012 05:50:21 -0700 (PDT) Message-ID: <50911079.7010404@googlemail.com> Date: Wed, 31 Oct 2012 13:50:17 +0200 From: =?UTF-8?B?RnJhbmsgU2Now6RmZXI=?= MIME-Version: 1.0 To: benny+usenet@amorsen.dk CC: linux-media@vger.kernel.org Subject: Re: [PATCH 00/23] em28xx: add support fur USB bulk transfers References: <1350838349-14763-1-git-send-email-fschaefer.oss@googlemail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Benny, Am 31.10.2012 03:39, schrieb Benny Amorsen: > Frank Schäfer writes: > >> This patch series adds support for USB bulk transfers to the em28xx driver. > I tried these patches on my Raspberry Pi, 3.6.1 kernel, Nanostick 290e Thank you for testing ! > options em28xx prefer_bulk=1 core_debug=1 usb_debug=1 > options em28xx_dvb debug=1 > > [ 5.469510] em28xx: New device PCTV Systems PCTV 290e @ 480 Mbps (2013:024f, interface 0, class 0) > [ 5.890637] em28xx: DVB interface 0 found > [ 6.025292] em28xx #0: chip ID is em28174 > [ 6.515383] em28xx #0: Identified as PCTV nanoStick T2 290e (card=78) > [ 6.567066] em28xx #0: v4l2 driver version 0.1.3 > [ 6.614720] em28xx #0 em28xx_set_alternate :minimum isoc packet size: 2888 (alt=0) > [ 6.663064] em28xx #0 em28xx_set_alternate :setting alternate 0 with wMaxPacketSize=0 > [ 6.715934] em28xx #0 em28xx_accumulator_set :em28xx Scale: (1,1)-(179,143) > [ 6.765694] em28xx #0 em28xx_capture_area_set :em28xx Area Set: (180,144) > [ 6.793060] em28xx #0: V4L2 video device registered as video0 > [ 6.808200] em28xx #0 em28xx_alloc_urbs :em28xx: called em28xx_alloc_isoc in mode 2 > [ 6.819456] em28xx #0: no endpoint for DVB mode and transfer type 1 > [ 6.829283] em28xx: Failed to pre-allocate USB transfer buffers for DVB. > [ 6.839454] em28xx: probe of 1-1.3.1:1.0 failed with error -22 > [ 6.852511] usbcore: registered new interface driver em28xx > [ 7.255738] em28xx #0 em28xx_accumulator_set :em28xx Scale: (1,1)-(179,143) > [ 7.291575] em28xx #0 em28xx_capture_area_set :em28xx Area Set: (180,144) > [ 7.326200] em28xx #0 em28xx_uninit_usb_xfer :em28xx: called em28xx_uninit_usb_xfer in mode 1 > > Is the Nanostick 290e just fundamentally incompatible with bulk > transfers, or is there hope yet? It seems like your device has no bulk endpoint for DVB. What does lsusb say ? The module parameter is called prefer_bulk, but what it actually does is "force bulk" (which doesn't make much sense when the device has no bulk endpoints). I will fix this in v2 of the patch series. > It works great with isochronous transfers on my PC and the Fedora > kernel, but the Raspberry USB host blows up when trying to do > isochronous mode. Is this a regression caused by patches or a general issue with the Raspberry board ? Regards, Frank > /Benny