Re: [Qemu-devel] [PATCH 1/4] usb: split packet result into actual_length + status

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 10/19/2012 11:00 AM, Gerd Hoffmann wrote:
>    Hi,
>
>> This patch unfortunately is somewhat invasive, since makeing the qemu
>> usb core deal with this requires changes everywhere. This patch only
>> prepares the usb core for this, all the hcd / device changes are done
>> in such a way that there are no functional changes.
>
> /me likes it.
>
> When touching this _anyway_:  How about making usb_handle_packet and
> ->handle_data callbacks return void (or bool for completed/async) and
> expect drivers to fill the fields in USBPacket instead?  That would kill
> a little annonying difference in sync/async packet handling.

Ok, I've redone the patchset making usb_handle_packet and
the device's handle_control and handle_data methods return void, to
make the sync/async packet handling more alike.

This turned out to be quite a bit of work! But is all done now,
and it has been thoroughly tested (although with a subset
of all supported / emulated qemu usb devices, see the
commit message).

Regards,

Hans