All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Robin van der Gracht <robin@protonic.nl>, dwmw2@infradead.org
Cc: sjhill@realitydiluted.com, tglx@linutronix.de,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: Take celltype into account when parsing Samsung ext. nand ID's
Date: Wed, 31 Oct 2012 09:17:54 -0700	[thread overview]
Message-ID: <50914F32.7020605@gmail.com> (raw)
In-Reply-To: <1351679539-30651-1-git-send-email-robin@protonic.nl>

Hi Robin,

On 10/31/2012 03:32 AM, Robin van der Gracht wrote:
> When using a Samsung nandflash with 2 level cells, the wrong page size,
> erase size and oobsize is calculated.
>
> I'm using a Samsung K9K8G08U0B nandflash (ID: 0xECD3519558). When booting the kernel i get:
> NAND device: Manufacturer ID: 0xec, Chip ID: 0xd3 (Samsung NAND 1GiB 3,3V 8-bit), page size: 4096, OOB size: 128
>
> This is wrong. My nand flash has a pagesize of 2048 and oobsize 64.
>
> This patch should work for all Samsung 6 byte ID chips, found on:
> http://www.linux-mtd.infradead.org/nand-data/nanddata.html
>
> Signed-off-by: Robin van der Gracht <robin@protonic.nl>

I believe this regression has already been fixed and accepted by David 
Woodhouse and is awaiting upstream submission - hopefully for the 3.7-rc 
cycle. This should be its ID, in linux-mtd.git (and linux-next):

commit bc86cf7af2ebda88056538e8edff852ee627f76a
mtd: nand: fix Samsung SLC NAND identification regression

http://lists.infradead.org/pipermail/linux-mtd/2012-October/044458.html

Please test this fix to see if it fixes your problem, if possible. BTW, 
I would prefer not to use your solution, as the new Samsung ID decode 
table actually applies to some 2-level (i.e., SLC) Samsung NAND, 
particularly K9FAG08U0M.

Brian

  reply	other threads:[~2012-10-31 16:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31 10:32 [PATCH] mtd: nand: Take celltype into account when parsing Samsung ext. nand ID's Robin van der Gracht
2012-10-31 16:17 ` Brian Norris [this message]
2012-10-31 16:30   ` David Woodhouse
2012-10-31 17:18     ` Brian Norris
2012-11-01  6:54     ` Artem Bityutskiy
2012-11-08  8:03     ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50914F32.7020605@gmail.com \
    --to=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=robin@protonic.nl \
    --cc=sjhill@realitydiluted.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.