From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 31 Oct 2012 19:16:57 +0100 (CET) Received: from mail-pb0-f49.google.com ([209.85.160.49]:62676 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6825756Ab2JaSQ46BJvr (ORCPT ); Wed, 31 Oct 2012 19:16:56 +0100 Received: by mail-pb0-f49.google.com with SMTP id xa7so1090014pbc.36 for ; Wed, 31 Oct 2012 11:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=sNWWWo5j/3xoxGXpVGa0Vm9Mc/F6CSlF1Zz8utIWrdI=; b=YMw2Pezxb6QqEBtaESRtifsaVCZIDlvlXRlWoCIRkJqhoCLfSFRTZx81sB771w6RF/ LuCB2N3bGwfnW4siTaSb0Dav9oHa4rR40y/W0RWY93M5eM1ny18jf/z7X/iUmY4KzUg1 vgNookMb7VPVbc3OAMAlIzNUiDk9S/5MlKR4LKDAb4FwBCqlHdM/NqNskpQxYSFyqvu3 H7DwruIisDrAQQevA7nJJYNT31yuFqS+/AKIZy5VgxvWv7RGxSvGozNxrZDmhFMVnSlq f+EZw8FDB9NQPdzFSiBMwUb1CBfiDav/ryKs7DbhzdpsHsOG2hAXizXn1xjRSc7NTOki KF8Q== Received: by 10.66.90.33 with SMTP id bt1mr103587969pab.49.1351707410155; Wed, 31 Oct 2012 11:16:50 -0700 (PDT) Received: from dl.caveonetworks.com (64.2.3.195.ptr.us.xo.net. [64.2.3.195]) by mx.google.com with ESMTPS id zv10sm2626916pbc.76.2012.10.31.11.16.28 (version=SSLv3 cipher=OTHER); Wed, 31 Oct 2012 11:16:47 -0700 (PDT) Message-ID: <50916AFB.1040903@gmail.com> Date: Wed, 31 Oct 2012 11:16:27 -0700 From: David Daney User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1 MIME-Version: 1.0 To: Sanjay Lal CC: kvm@vger.kernel.org, linux-mips@linux-mips.org Subject: Re: [PATCH 12/20] KVM/MIPS32: Routines to handle specific traps/exceptions while executing the guest. References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-archive-position: 34835 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ddaney.cavm@gmail.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Return-Path: On 10/31/2012 08:20 AM, Sanjay Lal wrote: > Signed-off-by: Sanjay Lal > --- > arch/mips/kvm/kvm_cb.c | 16 ++ > arch/mips/kvm/kvm_trap_emul.c | 446 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 462 insertions(+) > create mode 100644 arch/mips/kvm/kvm_cb.c > create mode 100644 arch/mips/kvm/kvm_trap_emul.c > At a minimum you should probably follow Documentation/CodingStyle Running checkpatch.pl on all the patches and fixing obvious problems is always a good idea. > diff --git a/arch/mips/kvm/kvm_cb.c b/arch/mips/kvm/kvm_cb.c > new file mode 100644 > index 0000000..768198e > --- /dev/null > +++ b/arch/mips/kvm/kvm_cb.c > @@ -0,0 +1,16 @@ > +/* > +* This file is subject to the terms and conditions of the GNU General Public > +* License. See the file "COPYING" in the main directory of this archive > +* for more details. > +* > +* PUT YOUR TITLE AND/OR INFORMATION FOR THE FILE HERE That line can probably be safely removed. > +* > +* Copyright (C) 2012 MIPS Technologies, Inc. All rights reserved. > +* Authors: Yann Le Du > +*/ . . . David Daney