Re: WARNING in agg-tx.c (3.5.7+, not tainted)

[Ben Greear <greearb@candelatech.com>]

On 10/31/2012 12:20 PM, Johannes Berg wrote:
> On Wed, 2012-10-31 at 12:18 -0700, Ben Greear wrote:
>
>>>> 	mutex_lock(&sta->ampdu_mlme.mtx);
>>>> 	tid_tx = rcu_dereference_protected_tid_tx(sta, tid);
>>>>
>>>> 	if (WARN_ON(!tid_tx)) {
>>>> #ifdef CONFIG_MAC80211_HT_DEBUG
>>>> 		printk(KERN_DEBUG "addBA was not requested!\n");
>>>> #endif
>>>
>>> Hm should probably be a WARN(), but ...
>>>
>>> >From the backtrace it looks like maybe you were tearing down the
>>> interface? So maybe it's possible that you were remove it or something,
>>> and the driver had just accepted the session? Hmm.
>>
>> I've got 400 interfaces churning, some being reset due to lack of
>> fast enough DHCP response, etc.  Could easily be related to that
>> drv-remove-interface bug as well..
>
> I didn't even think of that, but yeah, that seems possible.
>
>> it is much more easily reproduced
>> in this scenario.  Will re-run some tests with your suggested patch
>> applied...
>
> Ok cool.

Unfortunately, it still happens even with the other patch applied.

I have only seen it once in several hours of testing, and it doesn't
seem to cause any lasting harm.

But, I have at least some sort of test case for it, so
if you have a suggested patch, I'll be happy to test it.

Thanks,
Ben

>
> johannes
>


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com