From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tang Chen Subject: Re: [PATCH v3 1/3] Use acpi_os_hotplug_execute() instead of alloc_acpi_hp_work(). Date: Thu, 01 Nov 2012 14:07:27 +0800 Message-ID: <5092119F.1000600@cn.fujitsu.com> References: <1351668471-31436-1-git-send-email-tangchen@cn.fujitsu.com> <1351668471-31436-2-git-send-email-tangchen@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-pci-owner@vger.kernel.org To: Yinghai Lu Cc: bhelgaas@google.com, lenb@kernel.org, jiang.liu@huawei.com, izumi.taku@jp.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-acpi@vger.kernel.org On 11/01/2012 11:52 AM, Yinghai Lu wrote: > On Wed, Oct 31, 2012 at 12:27 AM, Tang Chen wrote: > Please check if you can just fold > acpi_hp_cb_execute > callers, and use acpi_os_hotplug_execute directly. > > and have two local conext struct too. > I think this could bring some duplicated work. We need to do the same work every time we call acpi_os_hotplug_execute(), what has been done in acpi_hp_cb_execute(). I can try to modify it and resend a new patch to see if it is better. Thanks. :)