From: Shan Wei <shanwei88@gmail.com>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: Christoph Lameter <cl@linux.com>,
steffen.klassert@secunet.com, David Miller <davem@davemloft.net>,
NetDev <netdev@vger.kernel.org>,
Kernel-Maillist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/9] net: xfrm: use this_cpu_ptr per-cpu helper
Date: Thu, 01 Nov 2012 17:00:56 +0800 [thread overview]
Message-ID: <50923A48.1080906@gmail.com> (raw)
In-Reply-To: <20121101034136.GA27343@gondor.apana.org.au>
Herbert Xu said, at 2012/11/1 11:41:
> Please refer to the comment in the patch above.
>
> But I think the patch is wrong anyway because it would introduce
> a warning, no?
yes, __this_cpu_ptr(or __this_cpu_read) is more reasonable
which don't check preemption context.
>
> Thanks,
>
next prev parent reply other threads:[~2012-11-01 9:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 11:22 [PATCH 3/9] net: xfrm: use this_cpu_ptr per-cpu helper Shan Wei
2012-10-31 17:35 ` Christoph Lameter
2012-11-01 3:41 ` Herbert Xu
2012-11-01 9:00 ` Shan Wei [this message]
2012-11-01 8:56 ` Shan Wei
2012-11-01 9:18 ` Steffen Klassert
2012-11-01 12:15 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50923A48.1080906@gmail.com \
--to=shanwei88@gmail.com \
--cc=cl@linux.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.