From: Alex Elder <elder@inktank.com>
To: ceph-devel@vger.kernel.org
Subject: [PATCH 4/5] rbd: don't use ENOTSUPP
Date: Thu, 01 Nov 2012 08:55:22 -0500 [thread overview]
Message-ID: <50927F4A.1090404@inktank.com> (raw)
In-Reply-To: <50927D03.9060900@inktank.com>
ENOTSUPP is not a standard errno (it shows up as "Unknown error 524"
in an error message). This is what was getting produced when the
the local rbd code does not implement features required by a
discovered rbd image.
Change the error code returned in this case to ENXIO.
Signed-off-by: Alex Elder <elder@inktank.com>
---
drivers/block/rbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 6512a8e..3378963 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -2465,7 +2465,7 @@ static int _rbd_dev_v2_snap_features(struct
rbd_device *rbd_dev, u64 snap_id,
incompat = le64_to_cpu(features_buf.incompat);
if (incompat & ~RBD_FEATURES_ALL)
- return -ENOTSUPP;
+ return -ENXIO;
*snap_features = le64_to_cpu(features_buf.features);
--
1.7.9.5
next prev parent reply other threads:[~2012-11-01 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 13:45 [PATCH 0/5] rbd: little cleanups Alex Elder
2012-11-01 13:48 ` [PATCH 1/5] rbd: document rbd_spec structure Alex Elder
2012-11-01 13:53 ` [PATCH 2/5] rbd: kill rbd_spec->image_name_len Alex Elder
2012-11-01 13:54 ` [PATCH 3/5] rbd: kill rbd_spec->image_id_len Alex Elder
2012-11-01 13:55 ` Alex Elder [this message]
2012-11-01 13:57 ` [PATCH 5/5] rbd: use kmemdup() Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50927F4A.1090404@inktank.com \
--to=elder@inktank.com \
--cc=ceph-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.