Re: [PATCH 01/20] KVM/MIPS32: Infrastructure/build files.

[Avi Kivity <avi@redhat.com>]

On 10/31/2012 05:17 PM, Sanjay Lal wrote:
> - Add the KVM option to MIPS build files.
> - Add default config files for KVM host/guest kernels.
> - Change the link address for the Malta KVM Guest kernel to UM (0x40100000).
> - Add KVM Kconfig file with KVM/MIPS specific options
> 
> index dba9390..8ac1aa1 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -1284,6 +1284,8 @@ config CPU_MIPS32_R2
>  	select CPU_HAS_PREFETCH
>  	select CPU_SUPPORTS_32BIT_KERNEL
>  	select CPU_SUPPORTS_HIGHMEM
> +    select HAVE_KVM
> +    
>  	help
>  	  Choose this option to build a kernel for release 2 or later of the
>  	  MIPS32 architecture.  Most modern embedded systems with a 32-bit
> @@ -1789,6 +1791,21 @@ config 64BIT
>  
>  endchoice
>  
> +config KVM_GUEST
> +   bool "KVM Guest Kernel"
> +   depends on HAVE_KVM 
> +   help
> +    Select this option if building a guest kernel for KVM (Trap & Emulate) mode


HAVE_KVM indicates that the host has virtualization support for KVM.  It
says nothing about the guest.  So KVM_GUEST need not depend on HAVE_KVM.

> +
> +config KVM_HOST_FREQ
> +    int "KVM Host Processor Frequency (MHz)"
> +    depends on HAVE_KVM 
> +    default 500
> +    help
> +      Select this option if building a guest kernel for KVM to skip
> +      RTC emulation when determining guest CPU Frequency.  Instead, the guest
> +      processor frequency is automatically derived from the host frequency.
> +

And this should depend on KVM_GUEST (or be avoided completely, why not
use it always?)



-- 
error compiling committee.c: too many arguments to function