From: Jan Schmidt <list.btrfs@jan-o-sch.net>
To: Chris Mason <chris.mason@fusionio.com>
Cc: Chris Mason <clmason@fusionio.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"ablock84@googlemail.com" <ablock84@googlemail.com>,
"sensille@gmx.net" <sensille@gmx.net>
Subject: Re: [PATCH 0/2] Btrfs-progs: urgent fixes for btrfs send
Date: Thu, 01 Nov 2012 16:48:25 +0100 [thread overview]
Message-ID: <509299C9.7050509@jan-o-sch.net> (raw)
In-Reply-To: <20121101150710.GA21281@shiny>
On Thu, November 01, 2012 at 16:07 (+0100), Chris Mason wrote:
> On Thu, Nov 01, 2012 at 09:01:24AM -0600, Jan Schmidt wrote:
>> Hi everybody,
>>
>> We made a bad mistake with "btrfs send" command line arguments and we'd
>> better fix it before it's being widely used (read: *now*).
>
> Ok, I do agree that -i was confusing. I didn't end up using it in my
> backup scripts here.
Good we agree here :-)
> How about:
>
> Make -p and -i mean the same thing. Add -r for what -i should have
> done.
>
> This has the advantage of not breaking the people that did get working
> btrfs send setups ;)
I'd carefully argue that we're still in the position to break things, because
the 3.7 kernel isn't released and you cannot use "btrfs send" without it. The
number of users should be really small.
I prefer having a clean and painful cut over suffering from bad decisions
forever. That may not be the most popular opinion in the world. In the end, I
could live with -p and -i doing the same thing.
-Jan
next prev parent reply other threads:[~2012-11-01 15:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 15:01 [PATCH 0/2] Btrfs-progs: urgent fixes for btrfs send Jan Schmidt
2012-11-01 15:01 ` [PATCH 1/2] Btrfs-progs: correcting misnamed parameter options " Jan Schmidt
2012-11-01 15:01 ` [PATCH 2/2] Btrfs-progs: bugfix for subvolume parent determination in " Jan Schmidt
2012-11-01 15:07 ` [PATCH 0/2] Btrfs-progs: urgent fixes for " Chris Mason
2012-11-01 15:48 ` Jan Schmidt [this message]
2012-11-01 18:46 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509299C9.7050509@jan-o-sch.net \
--to=list.btrfs@jan-o-sch.net \
--cc=ablock84@googlemail.com \
--cc=chris.mason@fusionio.com \
--cc=clmason@fusionio.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sensille@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.