All of lore.kernel.org
 help / color / mirror / Atom feed
From: Goffredo Baroncelli <kreijack@inwind.it>
To: "Fajar A. Nugraha" <list@fajar.net>
Cc: cwillu <cwillu@cwillu.com>, Anand jain <Anand.Jain@oracle.com>,
	linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [Request for review] [RFC] Add label support for snapshots and subvols
Date: Fri, 02 Nov 2012 00:04:59 +0100	[thread overview]
Message-ID: <5093001B.9080009@inwind.it> (raw)
In-Reply-To: <CAG1y0sd-F6WrUFsvwAx+7LGD+V7a6XCoP9=XEkADPEAyEL1G1w@mail.gmail.com>

On 11/01/2012 11:28 PM, Fajar A. Nugraha wrote:
> On Fri, Nov 2, 2012 at 5:16 AM, cwillu <cwillu@cwillu.com> wrote:
>>>  btrfs fi label -t /btrfs/snap1-sv1
>>> Prod-DB-sand-box-testing
>>
>> Why is this better than:
>>
>> # btrfs su snap /btrfs/Prod-DB /btrfs/Prod-DB-sand-box-testing
>> # mv /btrfs/Prod-DB-sand-box-testing /btrfs/Prod-DB-production-test
>> # ls /btrfs/
>> Prod-DB  Prod-DB-production-test
> 
> 
> ... because it would mean possibilty to decouple subvol name from
> whatever-data-you-need (in this case, a label).
> 

Could you elaborate how this solution is different from using xattr ?
I think also that these labels could be changed (like xattr). ?

These info should be associated to the inode of the subvolume root. We
could use a specific name in the system namespace, like
"system.btrfslabel" even tough I didn't see any advantage to using the
"user" namespace...


-- 
gpg @keyserver.linux.it: Goffredo Baroncelli (kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D  17B2 0EDA 9B37 8B82 E0B5

  parent reply	other threads:[~2012-11-01 23:04 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-01 10:46 [Request for review] [RFC] Add label support for snapshots and subvols Anand jain
2012-11-01 10:46 ` [PATCH 1/2] Btrfs-progs: move open_file_or_dir() to utils.c Anand jain
2012-11-01 10:46 ` [PATCH 2/2] Btrfs-progs: add feature to label subvol and snapshot Anand jain
2012-11-01 10:46 ` [PATCH] Btrfs: add label to snapshot and subvol Anand jain
2012-11-05  7:39   ` Jan Schmidt
2012-11-16  5:15     ` Anand Jain
2012-11-01 22:16 ` [Request for review] [RFC] Add label support for snapshots and subvols cwillu
2012-11-01 22:28   ` Fajar A. Nugraha
2012-11-01 22:32     ` Hugo Mills
2012-11-01 22:49       ` Fajar A. Nugraha
2012-11-05  7:24         ` Anand Jain
2012-11-05 23:22           ` David Sterba
2012-11-01 23:04     ` Goffredo Baroncelli [this message]
2012-11-16  4:52 ` [Request for review v2] " Anand jain
2012-11-16  4:52   ` [PATCH 1/3] Btrfs-progs: move open_file_or_dir() to utils.c Anand jain
2012-11-16  4:52   ` [PATCH v2] Btrfs: add label to snapshot and subvol Anand jain
2012-11-16  6:33     ` Miao Xie
2012-11-27 18:26       ` Anand Jain
2012-11-16  4:52   ` [PATCH 2/3] Btrfs-progs: add feature to label subvol and snapshot Anand jain
2012-11-16  4:52   ` [PATCH 3/3] Btrfs-progs: cmd option to show or set the subvol label Anand jain
2012-11-27 18:29 ` [Request for review v3] [RFC] Add label support for snapshots and subvols Anand jain
2012-11-27 18:29   ` [PATCH v3] Btrfs: add label to snapshot and subvol Anand jain
2012-11-28  3:05     ` Miao Xie
2012-11-28 10:02       ` Anand Jain
2012-11-28 10:25         ` Miao Xie
2012-11-28 12:17           ` Anand Jain
2012-11-28 12:15     ` Anand jain
2012-11-27 18:29   ` [PATCH 1/3] Btrfs-progs: move open_file_or_dir() to utils.c Anand jain
2012-11-27 18:29   ` [PATCH 2/3] Btrfs-progs: add feature to label subvol and snapshot Anand jain
2012-11-27 18:29   ` [PATCH 3/3] Btrfs-progs: cmd option to show or set the subvol label Anand jain
2012-11-30 15:47 ` [PATCH 0/3] Add subvol and snapshot attribute label Anand jain
2012-11-30 15:48   ` [PATCH 1/3] Btrfs-progs: move open_file_or_dir() to utils.c Anand jain
2012-11-30 15:48   ` [PATCH 2/3] Btrfs-progs: add attribute label for subvol and snapshot Anand jain
2012-11-30 15:48   ` [PATCH 3/3] Btrfs-progs: cmd option to show or set the subvol label Anand jain
2013-02-25  5:31 ` [PATCH 0/2 v4] Btrfs-progs: Add support for " Anand Jain
2013-02-25  5:31   ` [PATCH 1/2 v4] Btrfs-progs: add feature to label subvol and snapshot Anand Jain
2013-02-25  5:31   ` [PATCH 2/2 v4] Btrfs-progs: cmd option to show or set the subvol label Anand Jain
2013-02-25  5:31 ` [PATCH v4] Btrfs: Add support for " Anand Jain
2013-02-25  5:31   ` [PATCH v4] Btrfs: ability to add label to snapshot and subvol Anand Jain
2013-02-25 20:45     ` Hugo Mills
2013-03-01 10:36       ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5093001B.9080009@inwind.it \
    --to=kreijack@inwind.it \
    --cc=Anand.Jain@oracle.com \
    --cc=cwillu@cwillu.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=list@fajar.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.