From: John Fastabend <john.r.fastabend@intel.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH net-next 2/3] eth: Make is_link_local() consistent with other address tests
Date: Thu, 01 Nov 2012 17:33:31 -0700 [thread overview]
Message-ID: <509314DB.9060700@intel.com> (raw)
In-Reply-To: <1351797071.2883.13.camel@bwh-desktop.uk.solarflarecom.com>
On 11/1/2012 12:11 PM, Ben Hutchings wrote:
> Function name should include '_ether_addr'.
> Return type should be bool.
> Parameter name should be 'addr' not 'dest' (also matching kernel-doc).
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
Thanks for cleaning this up Ben.
Acked-by: John Fastabend <john.r.fastabend@intel.com>
next prev parent reply other threads:[~2012-11-02 0:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 19:11 [PATCH net-next 2/3] eth: Make is_link_local() consistent with other address tests Ben Hutchings
2012-11-02 0:33 ` John Fastabend [this message]
2012-11-03 1:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509314DB.9060700@intel.com \
--to=john.r.fastabend@intel.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.