From: Sam Lang <sam.lang@inktank.com>
To: Noah Watkins <jayhawk@cs.ucsc.edu>
Cc: ceph-devel@vger.kernel.org
Subject: Re: Assertion failure in ceph_readlink()
Date: Thu, 01 Nov 2012 20:29:26 -0500 [thread overview]
Message-ID: <509321F6.9060200@inktank.com> (raw)
In-Reply-To: <CAPrxi595hE+TWXA=9FTg=3aKhEqR+-yuYQYcNFk=u4oi2mL5hA@mail.gmail.com>
On 11/01/2012 06:22 PM, Noah Watkins wrote:
>> filepath path(relpath);
>> Inode *in;
>> - int r = path_walk(path, &in);
>> + int r = path_walk(path, &in, false);
>> if (r < 0)
>> return r;
>
> Fixes both cases. Thanks!
>
I discovered a few more bugs in path_walk() for the symlink case while
debugging your problem. I've pushed fixes and a test case to
wip-fix-symlinks.
-sam
next prev parent reply other threads:[~2012-11-02 1:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 22:38 Assertion failure in ceph_readlink() Noah Watkins
2012-11-01 23:13 ` Sam Lang
2012-11-01 23:22 ` Noah Watkins
2012-11-02 1:29 ` Sam Lang [this message]
2012-11-02 14:54 ` Noah Watkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509321F6.9060200@inktank.com \
--to=sam.lang@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=jayhawk@cs.ucsc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.