From: Eric Sandeen <sandeen@sandeen.net>
To: Ben Myers <bpm@sgi.com>
Cc: Dave Chinner <dchinner@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsdump:fill in bs_forkoff
Date: Thu, 01 Nov 2012 23:35:54 -0500 [thread overview]
Message-ID: <50934DAA.8070207@sandeen.net> (raw)
In-Reply-To: <20121031194654.GB9783@sgi.com>
On 10/31/12 2:46 PM, Ben Myers wrote:
> Hi Eric,
...
> It seemed like it could be an important bugfix but I wasn't really sure so I
> asked. Since it sounds like it's not a big deal, lets just hold off till after
> the release...
Well, I was wrong - at least at one point, I thought it was getting zeroed. (?!)
But Dave was running into trouble tonight ...
And as the git tree stands today, I'm getting checksum errors w/o this patch
too, and xfstests dump group is passing only with it added back in.
So I think you'd better pull it in, maybe change the commit message a bit
though - it downplays the importance too much I guess.
Sorry about that,
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-11-02 4:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 4:02 [PATCH] xfsdump:fill in bs_forkoff Eric Sandeen
2012-10-23 12:26 ` Christoph Hellwig
2012-10-30 19:47 ` Ben Myers
2012-10-30 19:54 ` Eric Sandeen
2012-10-31 19:46 ` Ben Myers
2012-11-02 4:35 ` Eric Sandeen [this message]
2012-11-02 5:15 ` Dave Chinner
2012-11-02 16:47 ` Ben Myers
2012-11-02 17:24 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50934DAA.8070207@sandeen.net \
--to=sandeen@sandeen.net \
--cc=bpm@sgi.com \
--cc=dchinner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.