From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUBeF-0008SY-4n for qemu-devel@nongnu.org; Fri, 02 Nov 2012 03:26:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TUBeD-0000fC-P3 for qemu-devel@nongnu.org; Fri, 02 Nov 2012 03:26:35 -0400 Received: from mout.web.de ([212.227.15.4]:49931) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUBeD-0000f7-EO for qemu-devel@nongnu.org; Fri, 02 Nov 2012 03:26:33 -0400 Message-ID: <509375A5.8020000@web.de> Date: Fri, 02 Nov 2012 08:26:29 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1351697456-16107-1-git-send-email-pbonzini@redhat.com> <1351697456-16107-16-git-send-email-pbonzini@redhat.com> In-Reply-To: <1351697456-16107-16-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig8D7A2AD34CC326642327E90A" Subject: Re: [Qemu-devel] [PATCH v2 15/39] vl: init main loop earlier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8D7A2AD34CC326642327E90A Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2012-10-31 16:30, Paolo Bonzini wrote: > Otherwise, chardevs will not be able to create a bottom half as soon > as that will require an AioContext. >=20 > Signed-off-by: Paolo Bonzini > --- > vl.c | 12 ++++++------ > 1 file modificato, 6 inserzioni(+), 6 rimozioni(-) >=20 > diff --git a/vl.c b/vl.c > index b3186fa..f84e969 100644 > --- a/vl.c > +++ b/vl.c > @@ -3311,6 +3311,12 @@ int main(int argc, char **argv, char **envp) > } > loc_set_none(); > =20 > + qemu_init_cpu_loop(); > + if (qemu_init_main_loop()) { > + fprintf(stderr, "qemu_init_main_loop failed\n"); > + exit(1); > + } > + > if (qemu_opts_foreach(qemu_find_opts("sandbox"), parse_sandbox, NU= LL, 0)) { > exit(1); > } > @@ -3463,12 +3469,6 @@ int main(int argc, char **argv, char **envp) > =20 > configure_accelerator(); > =20 > - qemu_init_cpu_loop(); > - if (qemu_init_main_loop()) { > - fprintf(stderr, "qemu_init_main_loop failed\n"); > - exit(1); > - } > - > machine_opts =3D qemu_opts_find(qemu_find_opts("machine"), 0); > if (machine_opts) { > kernel_filename =3D qemu_opt_get(machine_opts, "kernel"); >=20 This breaks daemonize as the BQL is marked as owned by the father process. See also [1] in this context. Can we move os_daemonize before that, or what are its dependencies? I have an increasingly bad feeling about this code shuffling. Jan [1] http://thread.gmane.org/gmane.comp.emulators.qemu/179311 --------------enig8D7A2AD34CC326642327E90A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlCTdaUACgkQitSsb3rl5xSvSgCgxfAqmwrW2LTglRmIWT0bO/eA QsEAnjwmniOwyNVmclOxBEuJqOiHhr1W =3dNX -----END PGP SIGNATURE----- --------------enig8D7A2AD34CC326642327E90A--