Re: [PATCH 3/4] staging:iio: add a callback buffer for in kernel push interface

[Jonathan Cameron <jic23@kernel.org>]

On 10/31/2012 02:10 PM, Peter Meerwald wrote:
> Hi,
> 
> I'm sure you missed my spellchecking :)
I am always happy to accept fixes like this that mean I don't look as
much of an idiot when patches hit mainline ;)
> 
>> +config IIO_BUFFER_CB
>> +       boolean "IIO callback buffer used for push in kernel interfaces"
>> +       help
>> +         Should be selected by any drivers that do inkernel push
>> +	 usage.  That is, those where the data is pushed to the consumer.
>> +
> 
> is it 'in kernel' or 'inkernel'? I'd prefer in-kernel :)
> indentation seems inconsistent
in-kernel is indeed nicer.  I'll do that here and maybe clean up the other uses later.

> 
>> +/**
>> + * iio_channel_cb_get_channels() - get access to the underlying channels.
>> + * @cb_buff:		The callback buffers from whom we want the channel
>> + *			information.
> 
> buffers from which?

actually should be 'buffer from whom'.
Good catch though - I could have read that 100 times and never noticed.

I'm lazy so won't repost the patch with these changes but will wait a little longer
then merge it if no one shouts loudly that I shouldn't. (they'll be in the wip
branch if anyone actually cares enough to look)