All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	"James E.J. Bottomley" <JBottomley@parallels.com>,
	linux-scsi@vger.kernel.org
Subject: Re: [patch 01/10] scsi: make __scsi_alloc_queue numa-aware
Date: Fri, 02 Nov 2012 12:31:37 +0100	[thread overview]
Message-ID: <5093AF19.5040707@acm.org> (raw)
In-Reply-To: <1351628084-29358-4-git-send-email-jmoyer@redhat.com>

On 10/30/12 21:14, Jeff Moyer wrote:
> Pass the numa node id set in the Scsi_Host on to blk_init_queue_node
> in order to keep all allocations local to the numa node the device is
> closest to.
>
> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
> ---
>   drivers/scsi/scsi_lib.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index da36a3a..8662a09 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -1664,7 +1664,7 @@ struct request_queue *__scsi_alloc_queue(struct Scsi_Host *shost,
>   	struct request_queue *q;
>   	struct device *dev = shost->dma_dev;
>
> -	q = blk_init_queue(request_fn, NULL);
> +	q = blk_init_queue_node(request_fn, NULL, shost->numa_node);
>   	if (!q)
>   		return NULL;

Hello Jeff,

I haven't seen the patch that introduces numa_node in struct Scsi_Host 
nor the cover letter of this patch series ? Have these been posted on 
the linux-scsi mailing list ?

Bart.

  reply	other threads:[~2012-11-02 11:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-30 20:14 [patch 00/10] make I/O path allocations more numa-friendly Jeff Moyer
2012-10-30 20:14 ` [patch 00/10] *** SUBJECT HERE *** Jeff Moyer
2012-10-30 20:14 ` [patch 00/10] make I/O path allocations more numa-friendly Jeff Moyer
2012-10-30 20:14 ` [patch 01/10] scsi: make __scsi_alloc_queue numa-aware Jeff Moyer
2012-11-02 11:31   ` Bart Van Assche [this message]
2012-11-02 14:19     ` Jeff Moyer
2012-10-30 20:14 ` [patch 02/10] scsi: make scsi_alloc_sdev numa-aware Jeff Moyer
2012-10-30 20:14 ` [patch 03/10] scsi: allocate scsi_cmnd-s from the device's local numa node Jeff Moyer
2012-10-30 20:14 ` [patch 04/10] sd: use alloc_disk_node Jeff Moyer
2012-10-30 20:14 ` [patch 05/10] vfs: pass data to alloc_inode super operation Jeff Moyer
     [not found]   ` <1351628084-29358-8-git-send-email-jmoyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2012-10-30 20:51     ` Al Viro
2012-10-30 20:51       ` Al Viro
2012-10-30 21:17       ` Al Viro
     [not found]         ` <20121030211701.GC2616-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2012-10-31 13:22           ` Jeff Moyer
2012-10-31 13:22             ` Jeff Moyer
2012-10-30 20:14 ` [patch 06/10] ata: use scsi_host_alloc_node Jeff Moyer
2012-10-30 20:14 ` [patch 07/10] megaraid_sas: " Jeff Moyer
2012-10-30 20:14 ` [patch 08/10] mpt2sas: " Jeff Moyer
2012-10-30 20:14 ` [patch 09/10] lpfc: " Jeff Moyer
2012-10-31 18:56   ` James Smart
2012-10-31 18:56     ` James Smart
2012-10-30 20:14 ` [patch 10/10] cciss: use blk_init_queue_node Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5093AF19.5040707@acm.org \
    --to=bvanassche@acm.org \
    --cc=JBottomley@parallels.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.