Re: [PATCH v2] Input: matrix-keypad - Add device tree support

[Stephen Warren <swarren@wwwdotorg.org>]

On 11/02/2012 02:21 AM, AnilKumar, Chimata wrote:
> On Wed, Oct 31, 2012 at 21:00:59, Stephen Warren wrote:
>> On 10/31/2012 05:54 AM, AnilKumar Ch wrote:
>>> Add device tree support to matrix keypad driver and usage details
>>> are added to device tree documentation. Driver was tested on AM335x
>>> EVM.
>>
>>> diff --git a/Documentation/devicetree/bindings/input/matrix-keypad.txt b/Documentation/devicetree/bindings/input/matrix-keypad.txt
>>> new file mode 100644
>>
>>> +- compatible:		Should be "gpio-matix-keypad"
>>
>> There's a typo there.
>>
>> Given that compatible value, shouldn't the file be named
>> gpio-matrix-keypad.txt then?
> 
> Stephen,
> 
> Thanks for the comments.
> 
> I agree and I have same thing in my mind but the driver name
> is matrix-keypad.c. And I think we have to change the driver
> file names as well. (drivers/../matrix_keypad.c, linux/input/
> matrix_keypad.h).

I don't think there's any requirement that the Linux driver source
filename needs to match the DT binding compatible value in any way.
Given the bindings are OS-agnostic, naming the binding file based on the
compatible value seems better than naming the binding based on the Linux
driver name when there's a discrepancy. I see you've renamed the file in
V3, so everything's fine.