From: Shan Wei <shanwei88@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: rostedt@goodmis.org, fweisbec@gmail.com,
Kernel-Maillist <linux-kernel@vger.kernel.org>,
mingo@redhat.com
Subject: Re: [PATCH 8/9] trace: use this_cpu_ptr per-cpu helper
Date: Fri, 02 Nov 2012 23:25:51 +0800 [thread overview]
Message-ID: <5093E5FF.5050000@gmail.com> (raw)
In-Reply-To: <0000013ab7f1e47a-68c5ce3c-06bb-48f8-93f7-1ce012b36a75-000000@email.amazonses.com>
Christoph Lameter said, at 2012/11/1 1:50:
>>
>> - buffer = per_cpu_ptr(percpu_buffer, smp_processor_id());
>> + buffer = this_cpu_ptr(percpu_buffer);
>>
>> return buffer->buffer;
>
>
> Just do a
>
> return this_cpu_read(percpu_buffer->buffer);
>
> and get rid of the this_cpu_ptr op
can not do that.
kernel/trace/trace.c:1515: error: incompatible types when assigning to type 'char[1024]' from type 'char *'
next prev parent reply other threads:[~2012-11-02 15:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 11:23 [PATCH 8/9] trace: use this_cpu_ptr per-cpu helper Shan Wei
2012-10-31 17:50 ` Christoph Lameter
2012-11-02 15:25 ` Shan Wei [this message]
2012-11-02 17:53 ` Christoph Lameter
2012-11-03 4:51 ` Shan Wei
2012-11-05 15:18 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5093E5FF.5050000@gmail.com \
--to=shanwei88@gmail.com \
--cc=cl@linux.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.