From: Paolo Bonzini <pbonzini@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, jan.kiszka@siemens.com
Subject: Re: [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches.
Date: Sat, 03 Nov 2012 15:24:36 +0100 [thread overview]
Message-ID: <50952924.7070405@redhat.com> (raw)
In-Reply-To: <509527DF.6040801@redhat.com>
Il 03/11/2012 15:19, Paolo Bonzini ha scritto:
> Il 03/11/2012 12:50, Blue Swirl ha scritto:
>> I'm still getting problems with Clang on Linux:
>>
>> CC qemu-sockets.o
>> /src/qemu/qemu-sockets.c:64:12: error: function
>> 'default_monitor_get_fd' is not needed and will not be emitted
>> [-Werror,-Wunneeded-internal-declaration]
>> static int default_monitor_get_fd(Monitor *mon, const char *name, Error **errp)
>> ^
>> /src/qemu/qemu-sockets.c:73:12: error: function
>> 'default_qemu_set_fd_handler2' is not needed and will not be emitted
>> [-Werror,-Wunneeded-internal-declaration]
>> static int default_qemu_set_fd_handler2(int fd,
>> ^
>> 2 errors generated.
>>
>> Perhaps the weak magic isn't so great after all.
>>
>
> It's a clang bug. The error should be suppressed, since the function is
> used with the weak alias.
>
> Or try if adding "|| defined __clang__" to compiler.h fixes it.
Other possible fixes include adding "inline" to the declarations, or of
course -Wno-unneeded-internal-declaration.
Paolo
next prev parent reply other threads:[~2012-11-03 14:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 14:43 [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches Paolo Bonzini
2012-11-02 14:43 ` [Qemu-devel] [PATCH v2 1/5] compiler: support Darwin weak references Paolo Bonzini
2012-11-05 7:50 ` TeLeMan
2012-11-02 14:43 ` [Qemu-devel] [PATCH v2 2/5] semaphore: implement fallback counting semaphores with mutex+condvar Paolo Bonzini
2012-11-02 14:43 ` [Qemu-devel] [PATCH v2 3/5] qemu-timer: reinitialize timers after fork Paolo Bonzini
2012-11-02 14:43 ` [Qemu-devel] [PATCH v2 4/5] vl: unify calls to init_timer_alarm Paolo Bonzini
2012-11-02 14:43 ` [Qemu-devel] [PATCH v2 5/5] vl: delay thread initialization after daemonization Paolo Bonzini
2012-11-02 15:12 ` [Qemu-devel] [PATCH v2 0/5] Fixes for thread pool patches Peter Maydell
2012-11-03 11:50 ` Blue Swirl
2012-11-03 14:19 ` Paolo Bonzini
2012-11-03 14:24 ` Paolo Bonzini [this message]
2012-11-03 15:26 ` Blue Swirl
2012-11-03 15:51 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50952924.7070405@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.