From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH 11/15] ARM: OMAP: timer: Interchange clksrc and clkevt for AM33XX Date: Sat, 3 Nov 2012 22:01:46 +0530 Message-ID: <509546F2.8080505@ti.com> References: <1351859566-24818-1-git-send-email-vaibhav.bedia@ti.com> <1351859566-24818-12-git-send-email-vaibhav.bedia@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:41028 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757050Ab2KCQbz (ORCPT ); Sat, 3 Nov 2012 12:31:55 -0400 In-Reply-To: <1351859566-24818-12-git-send-email-vaibhav.bedia@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Vaibhav Bedia Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, khilman@ti.com, paul@pwsan.com, b-cousson@ti.com, tony@atomide.com On Friday 02 November 2012 06:02 PM, Vaibhav Bedia wrote: > AM33XX has only one usable timer in the WKUP domain. > Currently the timer instance in WKUP domain is used > as the clockevent and the timer in non-WKUP domain > as the clocksource. The timer in WKUP domain can keep > running in suspend from a 32K clock and hence serve > as the persistent clock. To enable this, interchange > the timers used as clocksource and clockevent for > AM33XX. A subsequent patch will add suspend-resume > support for the clockevent to ensure that there are > no issues with timekeeping. > > Signed-off-by: Vaibhav Bedia > --- > arch/arm/mach-omap2/timer.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c > index 565e575..6584ee0 100644 > --- a/arch/arm/mach-omap2/timer.c > +++ b/arch/arm/mach-omap2/timer.c > @@ -460,7 +460,7 @@ OMAP_SYS_TIMER(3_secure) > #endif > > #ifdef CONFIG_SOC_AM33XX > -OMAP_SYS_TIMER_INIT(3_am33xx, 1, OMAP4_MPU_SOURCE, 2, OMAP4_MPU_SOURCE) > +OMAP_SYS_TIMER_INIT(3_am33xx, 2, OMAP4_MPU_SOURCE, 1, OMAP4_MPU_SOURCE) > OMAP_SYS_TIMER(3_am33xx) > #endif > As mentioned on other patch comment, I think this might break your SOC idle. Regards Santosh From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Sat, 3 Nov 2012 22:01:46 +0530 Subject: [PATCH 11/15] ARM: OMAP: timer: Interchange clksrc and clkevt for AM33XX In-Reply-To: <1351859566-24818-12-git-send-email-vaibhav.bedia@ti.com> References: <1351859566-24818-1-git-send-email-vaibhav.bedia@ti.com> <1351859566-24818-12-git-send-email-vaibhav.bedia@ti.com> Message-ID: <509546F2.8080505@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Friday 02 November 2012 06:02 PM, Vaibhav Bedia wrote: > AM33XX has only one usable timer in the WKUP domain. > Currently the timer instance in WKUP domain is used > as the clockevent and the timer in non-WKUP domain > as the clocksource. The timer in WKUP domain can keep > running in suspend from a 32K clock and hence serve > as the persistent clock. To enable this, interchange > the timers used as clocksource and clockevent for > AM33XX. A subsequent patch will add suspend-resume > support for the clockevent to ensure that there are > no issues with timekeeping. > > Signed-off-by: Vaibhav Bedia > --- > arch/arm/mach-omap2/timer.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c > index 565e575..6584ee0 100644 > --- a/arch/arm/mach-omap2/timer.c > +++ b/arch/arm/mach-omap2/timer.c > @@ -460,7 +460,7 @@ OMAP_SYS_TIMER(3_secure) > #endif > > #ifdef CONFIG_SOC_AM33XX > -OMAP_SYS_TIMER_INIT(3_am33xx, 1, OMAP4_MPU_SOURCE, 2, OMAP4_MPU_SOURCE) > +OMAP_SYS_TIMER_INIT(3_am33xx, 2, OMAP4_MPU_SOURCE, 1, OMAP4_MPU_SOURCE) > OMAP_SYS_TIMER(3_am33xx) > #endif > As mentioned on other patch comment, I think this might break your SOC idle. Regards Santosh