From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUiow-0001mQ-62 for qemu-devel@nongnu.org; Sat, 03 Nov 2012 14:51:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TUiov-00071e-1o for qemu-devel@nongnu.org; Sat, 03 Nov 2012 14:51:50 -0400 Received: from mout.web.de ([212.227.17.12]:50786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUiou-00071Z-OR for qemu-devel@nongnu.org; Sat, 03 Nov 2012 14:51:48 -0400 Message-ID: <509567BE.9000306@web.de> Date: Sat, 03 Nov 2012 19:51:42 +0100 From: Jan Kiszka MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigFCB8A47FD823B1C4EABA1C37" Subject: Re: [Qemu-devel] [PATCH] kvm: fix Win2k boot without KVM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFCB8A47FD823B1C4EABA1C37 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2012-11-03 19:49, Blue Swirl wrote: > Ignore accesses to VAPIC when kvmvapic is not enabled. >=20 > Cc: Jan Kiszka > Signed-off-by: Blue Swirl > --- > hw/kvmvapic.c | 7 ++++--- > 1 files changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/hw/kvmvapic.c b/hw/kvmvapic.c > index dc111ee..a97d532 100644 > --- a/hw/kvmvapic.c > +++ b/hw/kvmvapic.c > @@ -612,6 +612,9 @@ static void vapic_write(void *opaque, hwaddr addr, = uint64_t data, > hwaddr rom_paddr; > VAPICROMState *s =3D opaque; > =20 > + if (!kvm_irqchip_in_kernel()) { > + return; > + } > cpu_synchronize_state(env); > =20 > /* > @@ -665,9 +668,7 @@ static void vapic_write(void *opaque, hwaddr addr, = uint64_t data, > break; > default: > case 4: > - if (!kvm_irqchip_in_kernel()) { > - apic_poll_irq(env->apic_state); > - } > + apic_poll_irq(env->apic_state); > break; > } > } >=20 NACK, I'm already debugging the true reason (related to code patching). Jan --------------enigFCB8A47FD823B1C4EABA1C37 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlCVZ8EACgkQitSsb3rl5xQ6ogCfU6U4lftf1XUj+fKn0+WGjjCT ozYAnjpcubbo0HKj549pTV14Uqf4mIbd =rXje -----END PGP SIGNATURE----- --------------enigFCB8A47FD823B1C4EABA1C37--