From: Jiri Slaby <jslaby@suse.cz>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jiri Slaby <jirislaby@gmail.com>,
jkosina@suse.cz, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd
Date: Sun, 04 Nov 2012 23:37:29 +0100 [thread overview]
Message-ID: <5096EE29.8090304@suse.cz> (raw)
In-Reply-To: <CAMuHMdWzNxhs1+14qwr0=G+_uGVWm9QKb4wBDBy-6rx5+pxv7w@mail.gmail.com>
On 11/04/2012 10:06 PM, Geert Uytterhoeven wrote:
> On Fri, Oct 19, 2012 at 1:28 PM, Jiri Slaby <jslaby@suse.cz> wrote:
>> + if ((quirks & MS_RDESC_3K) && *rsize == 106 &&
>> + !memcmp((char []){ 0x19, 0x00, 0x29, 0xff },
>> + &rdesc[94], 4)) {
>
> Which version of gcc are you using?
4.7.1. But that indeed fails too if memcmp is a macro. This is of course
not the case for x86, so that I didn't hit that. I will post a patch to
change this to standard array accesses. (This looked prettier though.)
@Greg: please drop that patch from the stable queues for now.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2012-11-04 22:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 11:28 [PATCH 1/1] HID: microsoft, fix invalid rdesc for 3k kbd Jiri Slaby
2012-10-22 9:00 ` Jiri Kosina
2012-11-04 21:06 ` Geert Uytterhoeven
2012-11-04 21:06 ` Geert Uytterhoeven
2012-11-04 22:37 ` Jiri Slaby [this message]
2012-11-05 8:05 ` Geert Uytterhoeven
2012-11-11 16:35 ` Geert Uytterhoeven
2012-11-11 16:35 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5096EE29.8090304@suse.cz \
--to=jslaby@suse.cz \
--cc=geert@linux-m68k.org \
--cc=jirislaby@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.