All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: "Zhang, Jun" <jun.zhang@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "x86@kernel.org" <x86@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Fleming, Matt" <matt.fleming@intel.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crash dump: don't delete non-E820_RAM during init
Date: Mon, 05 Nov 2012 03:39:12 +0100	[thread overview]
Message-ID: <509726D0.4010606@zytor.com> (raw)
In-Reply-To: <88DC34334CA3444C85D647DBFA962C270FD7F4B6@SHSMSX102.ccr.corp.intel.com>

On 11/05/2012 02:37 AM, Zhang, Jun wrote:
> Hello, Gortmaker
> I will modify my subject. Thanks!
> 
> Hello, Anvin
> from our three options, I think third option is better. But in 3) option, there are two choose, 3.1) is like memmap=REMOVERAM, 3.2) is memmap=CRASHKDUMP.
> In 3.1) we maybe need ifdef/endif within the { } of the function (like exactmap).
> In 3.2) we can remove the ifdef/endif. 
> Which one is the better? Maybe you have a better solution, please share it. 
> Thanks!
> 
> Next is our three option.
> 1)  my patch.
> 2)  modify kexec, only pass two parameters -- memmap=544K@64K 
>     memmap=64964K@32768K, in kernel setup_memory_map, we can remove RAM 
>     range.
> 3)  add extra optional, 3.1) like memmap=REMOVERAM
>                    3.2) like memmap=CRASHKDUMP
> 

Again, 2 would be better because it is a localized change to kexec.  If
that works I don't see why there is any reason to change anything else.

	-hpa



  reply	other threads:[~2012-11-05  2:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31  1:26 [PATCH] To crash dump, we need keep other memory type except E820_RAM, because other type come from BIOS or firmware is used by other code(for example: PCI_MMCONFIG) Zhang, Jun
2012-10-31  2:46 ` H. Peter Anvin
2012-10-31  3:39   ` Zhang, Jun
2012-10-31  4:38     ` H. Peter Anvin
2012-10-31  5:22       ` Zhang, Jun
2012-10-31  5:38         ` H. Peter Anvin
2012-11-01  2:15           ` Zhang, Jun
2012-11-01  4:20             ` H. Peter Anvin
2012-11-01  8:49               ` Zhang, Jun
2012-11-02 15:08                 ` Paul Gortmaker
2012-11-02 16:37                 ` H. Peter Anvin
2012-11-05  1:37                   ` [PATCH] crash dump: don't delete non-E820_RAM during init Zhang, Jun
2012-11-05  2:39                     ` H. Peter Anvin [this message]
2012-11-05  2:57                       ` Zhang, Jun
2012-11-05  2:59                         ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509726D0.4010606@zytor.com \
    --to=hpa@zytor.com \
    --cc=akpm@linux-foundation.org \
    --cc=jun.zhang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=mingo@redhat.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.