From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route Date: Mon, 05 Nov 2012 11:02:48 +0800 Message-ID: <50972C58.4010008@asianux.com> References: <50938A65.6040507@asianux.com> <5093BA27.3090109@asianux.com> <5093E953.5020709@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev To: Shan Wei Return-path: Received: from intranet.asianux.com ([58.214.24.6]:24552 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752276Ab2KEDBs (ORCPT ); Sun, 4 Nov 2012 22:01:48 -0500 In-Reply-To: <5093E953.5020709@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: > > 1. not to send same patch triple times. thanks, I shall notice, next time. (I shall 'believe' another members). > 2. config your email client,because tab is changed to space. > you can read Documentation/email-clients.txt. 1) thanks. I shall notice, next time. 2) now, I get gvim as extention editor for thounderbird 3) the patch is generated by `git format-patch -s --summary --stat` it use "' '\t" as head, I do not touch it, maybe it is correct. welcome any members to giving additional suggestions and completions. thanks the modified contents are below, ----------------------------------------------------------------------------------- the length of rt->dst.dev->name is 16 (IFNAMSIZ) in seq_printf, it is not suitable to use %8s for rt->dst.dev->name. so change it to %s, since each line has not been solid any more. additional information: %8s limit the width, not for the original string output length if name length is more than 8, it still can be fully displayed. if name length is less than 8, the ' ' will be filled before name. %.8s truly limit the original string output length (precision) Signed-off-by: Chen Gang --- net/ipv6/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index c42650c..b60bc52 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2835,7 +2835,7 @@ static int rt6_info_route(struct rt6_info *rt, void *p_arg) } else { seq_puts(m, "00000000000000000000000000000000"); } - seq_printf(m, " %08x %08x %08x %08x %8s\n", + seq_printf(m, " %08x %08x %08x %08x %s\n", rt->rt6i_metric, atomic_read(&rt->dst.__refcnt), rt->dst.__use, rt->rt6i_flags, rt->dst.dev ? rt->dst.dev->name : ""); -- 1.7.9.5