From: Gerd Hoffmann <kraxel@redhat.com>
To: David Gibson <dwg@au1.ibm.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] xhci: Fix some DMA host endian bugs
Date: Mon, 05 Nov 2012 11:20:09 +0100 [thread overview]
Message-ID: <509792D9.4030208@redhat.com> (raw)
In-Reply-To: <20121105042048.GY27695@truffula.fritz.box>
On 11/05/12 05:20, David Gibson wrote:
> Here's an updated version that uses a temporary buffer.
>
> From 588a8f874c8d5a658ef95e35164e182a915091db Mon Sep 17 00:00:00 2001
> From: David Gibson <david@gibson.dropbear.id.au>
> Date: Mon, 5 Nov 2012 14:29:01 +1100
> Subject: [PATCH] xhci: Fix some DMA host endian bugs
>
> The xhci device does correct endian switches on the results of some DMAs
> but not all. In particular, there are many DMAs of what are essentially
> arrays of 32-bit integers which never get byteswapped. This causes them
> to be interpreted incorrectly on big-endian hosts, since (as per the xhci
> spec) these arrays are always little-endian in guest memory.
>
> This patch adds some helper functions to fix these bugs. This may not be
> all the endian bugs in the xhci code, but it's certainly some of them and
> the Linux guest xhci driver certainly gets further with these fixes.
Patch added to usb patch queue.
thanks,
Gerd
next prev parent reply other threads:[~2012-11-05 10:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 2:32 [Qemu-devel] [PATCH] xhci: Fix some DMA host endian bugs David Gibson
2012-11-02 7:31 ` Gerd Hoffmann
2012-11-02 8:43 ` David Gibson
2012-11-05 4:20 ` David Gibson
2012-11-05 10:20 ` Gerd Hoffmann [this message]
2012-11-08 15:08 ` [Qemu-devel] xhci and ehci qemu emulation performance Stefano Panella
2012-11-08 15:20 ` Gerd Hoffmann
2012-11-08 15:32 ` Stefano Panella
2012-11-08 18:26 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509792D9.4030208@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=dwg@au1.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.