From: David Ahern <dsahern@gmail.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
Irina Tirdea <irina.tirdea@gmail.com>
Subject: Re: [PATCH 2/3] perf tools: Introduce struct hist_browser_timer
Date: Mon, 05 Nov 2012 08:25:29 -0700 [thread overview]
Message-ID: <5097DA69.7070505@gmail.com> (raw)
In-Reply-To: <1351835406-15208-2-git-send-email-namhyung@kernel.org>
On 11/1/12 11:50 PM, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> Currently various hist browser functions receive 3 arguments for
> refreshing histogram but only used from a few places. Also it's only
> for perf top command so that it can be NULL for other (and probably
> most) cases. Pack them into a struct in order to reduce number of
> those unused arguments.
>
> This is a mechanical change and does not intend a functional change.
>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Irina Tirdea <irina.tirdea@gmail.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> ---
> tools/perf/builtin-annotate.c | 2 +-
> tools/perf/builtin-report.c | 4 ++--
> tools/perf/builtin-top.c | 9 +++++---
> tools/perf/ui/browsers/annotate.c | 27 +++++++++++-------------
> tools/perf/ui/browsers/hists.c | 43 +++++++++++++++++----------------------
> tools/perf/ui/gtk/browser.c | 4 +---
> tools/perf/util/annotate.h | 8 ++++----
> tools/perf/util/hist.h | 28 ++++++++++++-------------
> 8 files changed, 58 insertions(+), 67 deletions(-)
Tested-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2012-11-05 15:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-02 5:50 [PATCH RESEND 1/3] perf tools: Use normalized arch name for searching objdump path Namhyung Kim
2012-11-02 5:50 ` [PATCH 2/3] perf tools: Introduce struct hist_browser_timer Namhyung Kim
2012-11-05 15:25 ` David Ahern [this message]
2012-11-14 7:23 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-11-02 5:50 ` [PATCH 3/3] perf report: Postpone objdump check until annotation requested Namhyung Kim
2012-11-05 15:25 ` David Ahern
2012-11-14 7:24 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-11-05 15:25 ` [PATCH RESEND 1/3] perf tools: Use normalized arch name for searching objdump path David Ahern
2012-11-14 7:22 ` [tip:perf/core] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5097DA69.7070505@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=irina.tirdea@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.