All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Durgin <josh.durgin@inktank.com>
To: Sage Weil <sage@inktank.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: explicitly specifying pgnum on pool creation
Date: Mon, 05 Nov 2012 10:55:31 -0800	[thread overview]
Message-ID: <50980BA3.20709@inktank.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1211040338400.30792@cobra.newdream.net>

On 11/04/2012 03:42 AM, Sage Weil wrote:
> The wip-explicit-pgnum changes the 'ceph osd pool create <name> <pgnum>'
> command to require the pg_num value instead of defaulting to 8.  This
> would make it harder for users to get this wrong.

I like this. It'd be great if we could add a pgnum argument to
'rados mkpool' and the corresponding librados pool_create* functions
too.

> On the other hand, it probably also breaks some scripts for deploying
> OpenStack that create volume and image pools.  :/

If those scripts are creating pools with 8 pgs, they're going to
create problems anyway. I don't mind breaking them as long as it's well
documented (i.e. release notes and docs on 'ceph osd pool create'
should mention the change).

> Ideas?
>
> The original idea was that the monitor would automagically notice when a
> small pgnum pool gets lots of objects and trigger a split.  Even if we
> don't do that, pretty soon now you'll be able to explicitly increase
> pg_num.  I still think it might be a good idea to require it up-front,
> though.

Until split is implemented and well-tested, I think it makes sense to
require it up-front. It's easy to relax that requirement later if we
want to make it more automatic.

> An alternative would be to default to a larger number (say, num_osds <<
> 2).  My concern there is that it makes it easy to create lots of pgs for
> pools that may be small, and it's still not large enough to get good
> performance for the "create pool, run rados bench" crowd.

It would also be easy to create too few pgs, and then add a bunch of
osds later.

Josh

  reply	other threads:[~2012-11-05 18:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-04 11:42 explicitly specifying pgnum on pool creation Sage Weil
2012-11-05 18:55 ` Josh Durgin [this message]
2012-11-05 19:35   ` Sage Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50980BA3.20709@inktank.com \
    --to=josh.durgin@inktank.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=sage@inktank.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.