From: Antti Palosaari <crope@iki.fi>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [media] tda18212: tda18218: use 'val' if initialized
Date: Tue, 06 Nov 2012 01:19:38 +0200 [thread overview]
Message-ID: <5098498A.9070707@iki.fi> (raw)
In-Reply-To: <1351803609.1597.16.camel@x61.thuisdomein>
On 11/01/2012 11:00 PM, Paul Bolle wrote:
> Commits e666a44fa313cb9329c0381ad02fc6ee1e21cb31 ("[media] tda18212:
> silence compiler warning") and e0e52d4e9f5bce7ea887027c127473eb654a5a04
> ("[media] tda18218: silence compiler warning") silenced warnings
> equivalent to these:
> drivers/media/tuners/tda18212.c: In function ‘tda18212_attach’:
> drivers/media/tuners/tda18212.c:299:2: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> drivers/media/tuners/tda18218.c: In function ‘tda18218_attach’:
> drivers/media/tuners/tda18218.c:305:2: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> But in both cases 'val' will still be used uninitialized if the calls
> of tda18212_rd_reg() or tda18218_rd_reg() fail. Fix this by only
> printing the "chip id" if the calls of those functions were successful.
> This allows to drop the uninitialized_var() stopgap measure.
>
> Also stop printing the return values of tda18212_rd_reg() or
> tda18218_rd_reg(), as these are not interesting.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
Acked-by: Antti Palosaari <crope@iki.fi>
Reviewed-by: Antti Palosaari <crope@iki.fi>
That patch does not make much sense, but I don't still see any reason to
reject it.
> ---
> 0) Compile tested only.
>
> drivers/media/tuners/tda18212.c | 6 +++---
> drivers/media/tuners/tda18218.c | 6 +++---
> 2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/tuners/tda18212.c b/drivers/media/tuners/tda18212.c
> index 5d9f028..e4a84ee 100644
> --- a/drivers/media/tuners/tda18212.c
> +++ b/drivers/media/tuners/tda18212.c
> @@ -277,7 +277,7 @@ struct dvb_frontend *tda18212_attach(struct dvb_frontend *fe,
> {
> struct tda18212_priv *priv = NULL;
> int ret;
> - u8 uninitialized_var(val);
> + u8 val;
>
> priv = kzalloc(sizeof(struct tda18212_priv), GFP_KERNEL);
> if (priv == NULL)
> @@ -296,8 +296,8 @@ struct dvb_frontend *tda18212_attach(struct dvb_frontend *fe,
> if (fe->ops.i2c_gate_ctrl)
> fe->ops.i2c_gate_ctrl(fe, 0); /* close I2C-gate */
>
> - dev_dbg(&priv->i2c->dev, "%s: ret=%d chip id=%02x\n", __func__, ret,
> - val);
> + if (!ret)
> + dev_dbg(&priv->i2c->dev, "%s: chip id=%02x\n", __func__, val);
> if (ret || val != 0xc7) {
> kfree(priv);
> return NULL;
> diff --git a/drivers/media/tuners/tda18218.c b/drivers/media/tuners/tda18218.c
> index 1819853..2d31aeb 100644
> --- a/drivers/media/tuners/tda18218.c
> +++ b/drivers/media/tuners/tda18218.c
> @@ -277,7 +277,7 @@ struct dvb_frontend *tda18218_attach(struct dvb_frontend *fe,
> struct i2c_adapter *i2c, struct tda18218_config *cfg)
> {
> struct tda18218_priv *priv = NULL;
> - u8 uninitialized_var(val);
> + u8 val;
> int ret;
> /* chip default registers values */
> static u8 def_regs[] = {
> @@ -302,8 +302,8 @@ struct dvb_frontend *tda18218_attach(struct dvb_frontend *fe,
>
> /* check if the tuner is there */
> ret = tda18218_rd_reg(priv, R00_ID, &val);
> - dev_dbg(&priv->i2c->dev, "%s: ret=%d chip id=%02x\n", __func__, ret,
> - val);
> + if (!ret)
> + dev_dbg(&priv->i2c->dev, "%s: chip id=%02x\n", __func__, val);
> if (ret || val != def_regs[R00_ID]) {
> kfree(priv);
> return NULL;
>
--
http://palosaari.fi/
prev parent reply other threads:[~2012-11-05 23:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 21:00 [PATCH] [media] tda18212: tda18218: use 'val' if initialized Paul Bolle
2012-11-05 23:19 ` Antti Palosaari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5098498A.9070707@iki.fi \
--to=crope@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.