All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: David Miller <davem@davemloft.net>,
	kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
	kaber@trash.net
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_stop
Date: Tue, 06 Nov 2012 09:11:52 +0800	[thread overview]
Message-ID: <509863D8.9020501@asianux.com> (raw)
In-Reply-To: <5097A030.5030209@asianux.com>

于 2012年11月05日 19:17, Chen Gang 写道:
> 
>   the length of ifp->idev->dev->name is 16 (IFNAMSIZ)
>   in seq_printf, it is not suitable to use %8s for rt->dst.dev->name.
>   so change it to %s, since each line has not been solid any more.
> 

1) sorry, the comments is incorrect
   need use ifp->idev->dev->name instead of rt->dst.dev->name in 2nd line.
   I will send it again.

2) By the way, the three patches "* %8s to %s *" are almost the same
   If need merge them into one patch, please tell me, I shall do.

   thanks.

-- 
Chen Gang

Asianux Corporation

  reply	other threads:[~2012-11-06  1:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-05 11:17 [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_stop Chen Gang
2012-11-06  1:11 ` Chen Gang [this message]
2012-11-06  1:42   ` Shan Wei
2012-11-06  1:57     ` Chen Gang
2012-11-06  3:04     ` Chen Gang
2012-11-06  1:13 ` Chen Gang
2012-11-06  1:21   ` Eric Dumazet
2012-11-06  1:26     ` Chen Gang
2012-11-06  1:29   ` [PATCH] net: ipv6: change %8s to %s for seq_printf of if6_seq_show Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=509863D8.9020501@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=davem@davemloft.net \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.