From: Stephen Warren <swarren@wwwdotorg.org>
To: Omar Ramirez Luna <omar.luna@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Russell King <linux@arm.linux.org.uk>,
Tony Lindgren <tony@atomide.com>,
Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>,
Loic PALLARDY <loic.pallardy@st.com>,
Arnd Bergmann <arnd@arndb.de>, Ohad Ben-Cohen <ohad@wizery.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Dom Cobley <popcornmix@gmail.com>,
Wim Van Sebroeck <wim@iguana.be>,
Linus Walleij <linus.walleij@linaro.org>,
Suman Anna <s-anna@ti.com>, Juan Gutierrez <jgutierrez@ti.com>,
Felipe Contreras <felipe.contreras@nokia.com>,
Tejun Heo <tj@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mailbox: OMAP: introduce mailbox framework
Date: Mon, 05 Nov 2012 20:40:18 -0700 [thread overview]
Message-ID: <509886A2.5060509@wwwdotorg.org> (raw)
In-Reply-To: <1352170552-29564-2-git-send-email-omar.luna@linaro.org>
On 11/05/2012 07:55 PM, Omar Ramirez Luna wrote:
> Actually moving it from plat-omap, as this framework/driver code is
> supposed to be under drivers/ folder. The framework should work with
> the current supported OMAP processors (OMAP1+) that have mailbox and
> can be used as a method of interprocessor communication.
>
> The mailbox hardware (in OMAP) uses a queued mailbox-interrupt mechanism
> that provides a communication channel between processors through a set of
> registers and their associated interrupt signals by sending and receiving
> messages.
> diff --git a/drivers/mailbox/mailbox.h b/drivers/mailbox/mailbox.h
Is this a public interface to the driver? If so, shouldn't the header be
in include/linux somewhere?
Is this a generic interface to any mailbox driver? If so, then I don't
think having "omap" in the symbol names is appropriate. If the header is
specific to the OMAP driver, I don't think using the very generic
filename "mailbox.h" is appropriate; use omap_mailbox.h instead?
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] mailbox: OMAP: introduce mailbox framework
Date: Mon, 05 Nov 2012 20:40:18 -0700 [thread overview]
Message-ID: <509886A2.5060509@wwwdotorg.org> (raw)
In-Reply-To: <1352170552-29564-2-git-send-email-omar.luna@linaro.org>
On 11/05/2012 07:55 PM, Omar Ramirez Luna wrote:
> Actually moving it from plat-omap, as this framework/driver code is
> supposed to be under drivers/ folder. The framework should work with
> the current supported OMAP processors (OMAP1+) that have mailbox and
> can be used as a method of interprocessor communication.
>
> The mailbox hardware (in OMAP) uses a queued mailbox-interrupt mechanism
> that provides a communication channel between processors through a set of
> registers and their associated interrupt signals by sending and receiving
> messages.
> diff --git a/drivers/mailbox/mailbox.h b/drivers/mailbox/mailbox.h
Is this a public interface to the driver? If so, shouldn't the header be
in include/linux somewhere?
Is this a generic interface to any mailbox driver? If so, then I don't
think having "omap" in the symbol names is appropriate. If the header is
specific to the OMAP driver, I don't think using the very generic
filename "mailbox.h" is appropriate; use omap_mailbox.h instead?
next prev parent reply other threads:[~2012-11-06 3:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 2:55 [PATCH v2 0/2] drivers: mailbox: omap-mailbox out of plat code Omar Ramirez Luna
2012-11-06 2:55 ` Omar Ramirez Luna
2012-11-06 2:55 ` [PATCH v2 1/2] mailbox: OMAP: introduce mailbox framework Omar Ramirez Luna
2012-11-06 2:55 ` Omar Ramirez Luna
2012-11-06 3:40 ` Stephen Warren [this message]
2012-11-06 3:40 ` Stephen Warren
2012-11-06 8:55 ` Linus Walleij
2012-11-06 8:55 ` Linus Walleij
2012-11-06 8:59 ` Greg Kroah-Hartman
2012-11-06 8:59 ` Greg Kroah-Hartman
2012-11-07 1:10 ` Omar Ramirez Luna
2012-11-07 1:10 ` Omar Ramirez Luna
2012-11-07 1:05 ` Omar Ramirez Luna
2012-11-07 1:05 ` Omar Ramirez Luna
2012-11-06 2:55 ` [PATCH v2 2/2] mailbox: split internal header from API header Omar Ramirez Luna
2012-11-06 2:55 ` Omar Ramirez Luna
2012-11-06 12:53 ` Loic PALLARDY
2012-11-06 12:53 ` Loic PALLARDY
2012-11-07 6:41 ` Omar Ramirez Luna
2012-11-07 6:41 ` Omar Ramirez Luna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509886A2.5060509@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=felipe.contreras@nokia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgutierrez@ti.com \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=loic.pallardy@st.com \
--cc=ohad@wizery.com \
--cc=omar.luna@linaro.org \
--cc=popcornmix@gmail.com \
--cc=s-anna@ti.com \
--cc=tj@kernel.org \
--cc=tony@atomide.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.