All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benoit Cousson <b-cousson@ti.com>
To: balbi@ti.com
Cc: Afzal Mohammed <afzal@ti.com>,
	Russell King <linux@arm.linux.org.uk>,
	Tony Lindgren <tony@atomide.com>,
	Rob Herring <rob.herring@calxeda.com>,
	Vaibhav Hiremath <hvaibhav@ti.com>,
	AnilKumar Ch <anilkumar@ti.com>, Ravi Babu <ravibabu@ti.com>,
	Santhapuri Damodar <damodar.santhapuri@ti.com>,
	Daniel Mack <zonque@gmail.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	devicetree-discuss@lists.ozlabs.org
Subject: Re: [PATCH v2] ARM: dts: AM33XX: Add usbss node
Date: Tue, 6 Nov 2012 16:32:31 +0100	[thread overview]
Message-ID: <50992D8F.1000200@ti.com> (raw)
In-Reply-To: <20121106142950.GA3056@arwen.pp.htv.fi>

On 11/06/2012 03:29 PM, Felipe Balbi wrote:
> Hi,
> 
> On Tue, Nov 06, 2012 at 07:59:38PM +0530, Afzal Mohammed wrote:
>> From: Ajay Kumar Gupta <ajay.gupta@ti.com>
>>
>> Device tree node for usbss on AM33XX. There are two musb
>> controllers on am33xx platform so have port0-mode and
>> port1-mode data.
>>
>> [afzal@ti.com: reg & interrupt property addition]
>>
>> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
>> Signed-off-by: Santhapuri, Damodar <damodar.santhapuri@ti.com>
>> Signed-off-by: Ravi Babu <ravibabu@ti.com>
>> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> 
> to my eyes, this looks ok.
> 
> Reviewed-by: Felipe Balbi <balbi@ti.com>

Thanks Felipe. Patch applied in for_3.8/dts_part2 branch.

Regards,
Benoit

> 
>> ---
>>
>> v2: node named as "usb"
>>
>> Depends on "usb: musb: dsps: dt binding - add resources, example"
>> (https://patchwork.kernel.org/patch/1704691/)
>>
>>  arch/arm/boot/dts/am33xx.dtsi | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>> index 5dfd682..20a3f29 100644
>> --- a/arch/arm/boot/dts/am33xx.dtsi
>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>> @@ -321,5 +321,22 @@
>>  			ti,hwmods = "spi1";
>>  			status = "disabled";
>>  		};
>> +
>> +		usb@47400000 {
>> +			compatible = "ti,musb-am33xx";
>> +			reg = <0x47400000 0x1000	/* usbss */
>> +			       0x47401000 0x800		/* musb instance 0 */
>> +			       0x47401800 0x800>;	/* musb instance 1 */
>> +			interrupts = <17		/* usbss */
>> +				      18		/* musb instance 0 */
>> +				      19>;		/* musb instance 1 */
>> +			multipoint = <1>;
>> +			num-eps = <16>;
>> +			ram-bits = <12>;
>> +			port0-mode = <3>;
>> +			port1-mode = <3>;
>> +			power = <250>;
>> +			ti,hwmods = "usb_otg_hs";
>> +		};
>>  	};
>>  };
>> -- 
>> 1.7.12
>>
> 


WARNING: multiple messages have this Message-ID (diff)
From: b-cousson@ti.com (Benoit Cousson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: dts: AM33XX: Add usbss node
Date: Tue, 6 Nov 2012 16:32:31 +0100	[thread overview]
Message-ID: <50992D8F.1000200@ti.com> (raw)
In-Reply-To: <20121106142950.GA3056@arwen.pp.htv.fi>

On 11/06/2012 03:29 PM, Felipe Balbi wrote:
> Hi,
> 
> On Tue, Nov 06, 2012 at 07:59:38PM +0530, Afzal Mohammed wrote:
>> From: Ajay Kumar Gupta <ajay.gupta@ti.com>
>>
>> Device tree node for usbss on AM33XX. There are two musb
>> controllers on am33xx platform so have port0-mode and
>> port1-mode data.
>>
>> [afzal at ti.com: reg & interrupt property addition]
>>
>> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
>> Signed-off-by: Santhapuri, Damodar <damodar.santhapuri@ti.com>
>> Signed-off-by: Ravi Babu <ravibabu@ti.com>
>> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> 
> to my eyes, this looks ok.
> 
> Reviewed-by: Felipe Balbi <balbi@ti.com>

Thanks Felipe. Patch applied in for_3.8/dts_part2 branch.

Regards,
Benoit

> 
>> ---
>>
>> v2: node named as "usb"
>>
>> Depends on "usb: musb: dsps: dt binding - add resources, example"
>> (https://patchwork.kernel.org/patch/1704691/)
>>
>>  arch/arm/boot/dts/am33xx.dtsi | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>> index 5dfd682..20a3f29 100644
>> --- a/arch/arm/boot/dts/am33xx.dtsi
>> +++ b/arch/arm/boot/dts/am33xx.dtsi
>> @@ -321,5 +321,22 @@
>>  			ti,hwmods = "spi1";
>>  			status = "disabled";
>>  		};
>> +
>> +		usb at 47400000 {
>> +			compatible = "ti,musb-am33xx";
>> +			reg = <0x47400000 0x1000	/* usbss */
>> +			       0x47401000 0x800		/* musb instance 0 */
>> +			       0x47401800 0x800>;	/* musb instance 1 */
>> +			interrupts = <17		/* usbss */
>> +				      18		/* musb instance 0 */
>> +				      19>;		/* musb instance 1 */
>> +			multipoint = <1>;
>> +			num-eps = <16>;
>> +			ram-bits = <12>;
>> +			port0-mode = <3>;
>> +			port1-mode = <3>;
>> +			power = <250>;
>> +			ti,hwmods = "usb_otg_hs";
>> +		};
>>  	};
>>  };
>> -- 
>> 1.7.12
>>
> 

  reply	other threads:[~2012-11-06 15:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-06 14:29 [PATCH v2] ARM: dts: AM33XX: Add usbss node Afzal Mohammed
2012-11-06 14:29 ` Afzal Mohammed
2012-11-06 14:29 ` Felipe Balbi
2012-11-06 14:29   ` Felipe Balbi
2012-11-06 15:32   ` Benoit Cousson [this message]
2012-11-06 15:32     ` Benoit Cousson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50992D8F.1000200@ti.com \
    --to=b-cousson@ti.com \
    --cc=afzal@ti.com \
    --cc=anilkumar@ti.com \
    --cc=balbi@ti.com \
    --cc=damodar.santhapuri@ti.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=hvaibhav@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=ravibabu@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=tony@atomide.com \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.