All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Mori, Naoyuki" <naoyuki.mori@intel.com>
Cc: dev@dpdk.org, "bjorn.topel@gmail.com" <bjorn.topel@gmail.com>,
	"Yao, Lei A" <lei.a.yao@intel.com>,
	"Topel, Bjorn" <bjorn.topel@intel.com>,
	"Zhang, Helin" <helin.zhang@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"Xu, Qian Q" <qian.q.xu@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [PATCH] examples/l3fwd: force CRC stripping for i40evf
Date: Thu, 10 Nov 2016 15:32:17 +0100	[thread overview]
Message-ID: <50996464.o08F9XFMCf@xps13> (raw)
In-Reply-To: <5952EEAD-ED55-4C0B-86EB-945B87637CD2@intel.com>

2016-11-10 13:50, Mori, Naoyuki:
> Hi,
> 
> >    Thomas wrote:
> >     > Just to make it sure, you mean returning an error in the driver when
> >     > a configuration cannot be applied, right?
> >    
> >    Yes, as in 1bbcc5d21129 ("i40evf: report error for unsupported CRC
> >    stripping config"), where -EINVAL is returned.
> >    
> >    Bj?rn
> 
> On my experience, OvS+DPDK has same issue.
> You cannot run OvS on i40evf due to this CRC config mismatch, while OvS on ixgbevf works fine.
> So, changing on i40evf PMD side would have more benefit, I believe.

No I think OVS should handle the configuration error.
We could also add a function to query this capability before configuring.

  reply	other threads:[~2016-11-10 14:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-10 13:50 [PATCH] examples/l3fwd: force CRC stripping for i40evf Mori, Naoyuki
2016-11-10 14:32 ` Thomas Monjalon [this message]
2016-11-10 14:43   ` Mori, Naoyuki
  -- strict thread matches above, loose matches on Subject: below --
2016-11-09  8:23 Björn Töpel
2016-11-09  8:37 ` Yao, Lei A
2016-11-09  9:28 ` Thomas Monjalon
2016-11-09  9:39   ` Björn Töpel
2016-11-09  9:46 ` Ananyev, Konstantin
2016-11-09 10:05   ` Björn Töpel
2016-11-09 10:22     ` Thomas Monjalon
2016-11-09 11:08     ` Ananyev, Konstantin
2016-11-09 11:27       ` Björn Töpel
2016-11-09 12:13         ` Ananyev, Konstantin
2016-11-09 13:01         ` Zhang, Helin
2016-11-09 13:09           ` Björn Töpel
2016-11-10  5:49             ` Yao, Lei A
2016-11-10  6:17               ` Björn Töpel
2016-11-10  7:55                 ` Thomas Monjalon
2016-11-10  7:59                   ` Björn Töpel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50996464.o08F9XFMCf@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bjorn.topel@gmail.com \
    --cc=bjorn.topel@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=lei.a.yao@intel.com \
    --cc=naoyuki.mori@intel.com \
    --cc=qian.q.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.